Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: static/css/main.css

Issue 29568555: Issue 5723 - Implement new abp.org content style guide (Closed) Base URL: https://bitbucket.org/adblockplus/adblockplus.org
Left Patch Set: Created Oct. 7, 2017, 3:33 p.m.
Right Patch Set: Addressed comments Created Oct. 9, 2017, 11:25 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « static/css/index-mobile.css ('k') | templates/default.tmpl » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 * 1 *
2 { 2 {
3 font-family: Arial, sans; 3 font-family: Arial, sans;
4 font-size: 16px; 4 font-size: 16px;
5 } 5 }
6 6
7 body 7 body
8 { 8 {
9 margin: 0; 9 margin: 0;
10 line-height: 1.5; 10 line-height: 1.5;
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
268 [dir="ltr"] .alert 268 [dir="ltr"] .alert
269 { 269 {
270 border-left: 5px solid #d14841; 270 border-left: 5px solid #d14841;
271 } 271 }
272 272
273 [dir="rtl"] .alert 273 [dir="rtl"] .alert
274 { 274 {
275 border-right: 5px solid #d14841; 275 border-right: 5px solid #d14841;
276 } 276 }
277 277
278 /******************************************************************************* 278 /******************************************************************************
279 * .content 279 * .content
280 ******************************************************************************/ 280 *****************************************************************************/
281 281
282 .content h5, 282 .content h1,
283 .content h2,
284 .content h3,
283 .content h4, 285 .content h4,
284 .content h3, 286 .content h5
285 .content h2,
286 .content h1
ire 2017/10/09 12:28:48 NIT (feel free to ignore if you don't agree): I th
juliandoucette 2017/10/09 23:28:53 I agree :D
287 { 287 {
288 font-weight: bold; 288 font-weight: bold;
289 margin: 30px 0px; 289 margin: 32px 0px;
juliandoucette 2017/10/07 15:50:07 (fallback in-case rem is not supported - this size
ire 2017/10/09 12:28:48 Acknowledged.
290 margin: 2rem 0rem; 290 margin: 2rem 0rem;
291 } 291 }
292 292
293 .content h5 {font-size: 1.1em;} 293 .content h1 { font-size: 2.4em; }
ire 2017/10/09 12:28:48 There should be spaces between the "{" and the sty
juliandoucette 2017/10/09 23:28:53 Acknowledged. (Doh)
294 .content h4 {font-size: 1.2em;} 294 .content h2 { font-size: 1.6em; }
295 .content h3 {font-size: 1.3em;} 295 .content h3 { font-size: 1.3em; }
296 .content h2 {font-size: 1.6em;} 296 .content h4 { font-size: 1.2em; }
297 .content h1 {font-size: 2.4em;} 297 .content h5 { font-size: 1.1em; }
298
299 .content footer,
juliandoucette 2017/10/07 15:50:08 I could have excluded this from this review as it
ire 2017/10/09 12:28:48 I think it should only be applied to the #site-foo
juliandoucette 2017/10/09 23:28:53 Agreed. The styleguide does specify this. But the
300 .content small
301 {
302 font-size: 0.9em;
303 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld