Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: lib/filterComposer.js

Issue 29570614: Issue 5028 - Use browser namespace (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Left Patch Set: Use callback-based API for storage Created Oct. 9, 2017, 4:01 p.m.
Right Patch Set: Update adblockplusui dependency Created Oct. 17, 2017, 1:02 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « lib/devtools.js ('k') | lib/filterValidation.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 200 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 { 211 {
212 readyPages.set(sender.page, null); 212 readyPages.set(sender.page, null);
213 updateContextMenu(sender.page); 213 updateContextMenu(sender.page);
214 }); 214 });
215 215
216 port.on("composer.openDialog", (message, sender) => 216 port.on("composer.openDialog", (message, sender) =>
217 { 217 {
218 return new Promise(resolve => 218 return new Promise(resolve =>
219 { 219 {
220 ext.windows.create({ 220 ext.windows.create({
221 url: ext.getURL("composer.html"), 221 url: browser.extension.getURL("composer.html"),
222 left: 50, 222 left: 50,
223 top: 50, 223 top: 50,
224 width: 420, 224 width: 420,
225 height: 200, 225 height: 200,
226 type: "popup" 226 type: "popup"
227 }, 227 },
228 popupPage => 228 popupPage =>
229 { 229 {
230 let popupPageId = popupPage.id; 230 let popupPageId = popupPage.id;
231 function onRemoved(removedPageId) 231 function onRemoved(removedPageId)
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
263 263
264 port.on("composer.quoteCSS", (message, sender) => 264 port.on("composer.quoteCSS", (message, sender) =>
265 { 265 {
266 return quoteCSS(message.CSS); 266 return quoteCSS(message.CSS);
267 }); 267 });
268 268
269 ext.pages.onLoading.addListener(page => 269 ext.pages.onLoading.addListener(page =>
270 { 270 {
271 page.sendMessage({type: "composer.content.finished"}); 271 page.sendMessage({type: "composer.content.finished"});
272 }); 272 });
LEFTRIGHT

Powered by Google App Engine
This is Rietveld