Issue 4580 - Replace ext.devtools with devtools

ext/common.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 143 matching lines @@
       return;
 
     let rawCatalog = JSON.parse(xhr.responseText);
     for (let msgId in rawCatalog)
     {
       if (!(msgId in catalog))
         catalog[msgId] = parseMessage(rawCatalog[msgId]);
     }
   };
 
+  /* Polyfills */
+
+  if (!("runtime" in chrome))
+    chrome.runtime = {};
+
+  chrome.runtime.onConnect = {
+    addListener(callback)
+    {
+      window.addEventListener("message", event =>
+      {
+        if (event.data.type == "connect")
+        {
+          callback({

[Manish Jethani, 2017/10/12 01:30:03]

Call the onConnect handler with a port object [1]

[1]: https://developer.chrome.com/apps/runtime#type-Port

+            postMessage(message)
+            {
+              event.source.postMessage({
+                type: "message",
+                messageId: -1,
+                payload: message
+              }, "*");
+            }
+          });
+        }
+      });
+    }
+  };
+
+  if (/\/devtools-panel\.html\b/.test(top.location.href))

[Sebastian Noack, 2017/10/17 21:40:25]

I suppose we could just check for:

  top.location.pathname == 'devtools-panel.html'

[Manish Jethani, 2017/10/18 00:26:53]

Done.

+  {
+    chrome.devtools = {
+      panels: {
+        openResource() {}
+      },
+
+      inspectedWindow: {
+        reload() {}
+      }
+    };
+  }
+
   chrome.i18n = {
     getUILanguage()
     {
       return locales[0].replace(/_/g, "-");
     },
     getMessage(msgId, substitutions)
     {
       while (true)
       {
         let message = catalog[msgId];
@@ skipping 14 matching lines @@
         if (locales.length == 0)
           return "";
 
         let locale = locales.shift();
         readCatalog(locale, "common.json");
         readCatalog(locale, catalogFile);
       }
     }
   };
 }());