#4612 - Enable External Commands in Nagios

modules/nagios/manifests/server.pp

Index: modules/nagios/manifests/server.pp
===================================================================
--- a/modules/nagios/manifests/server.pp
+++ b/modules/nagios/manifests/server.pp
@@ -50,10 +50,25 @@
     require => Package['php5-cgi']
   }
 
+  # See http://hub.eyeo.com/issues/4612#note-2
+  if $::operatingsystem == 'Debian' {
+    exec {'override-nagios-dpkg-stats':
+      command => 'dpkg-statoverride --update --add nagios www-data 2710 /var/lib/nagios3/rw && dpkg-statoverride --update --add nagios nagios 751 /var/lib/nagios3',

[mathias, 2017/10/25 10:31:47]

Please use shellquote() to aggregate the $command and $unless parameter values.
You should also be able to DRY (NRY?) by only exchanging the 2nd item / 1st
option value, e.g. "--update" and "--list".

[f.nicolaisen, 2017/10/25 14:36:09]

Acknowledged.

+      unless => 'dpkg-statoverride --list nagios www-data 2710 /var/lib/nagios3/rw && dpkg-statoverride --list nagios nagios 751 /var/lib/nagios3',
+      path => ["/usr/bin/", "/bin/"],
+      user => root,
+      notify => Service['nagios3'],
+      require => Package['nagios3'],
+    }
+  }
+
   service {'nagios3':
     ensure => running,
     enable => true,
-    require => [Package['nagios3'], Package['pnp4nagios']]
+    require => [
+      Package['nagios3'],
+      Package['pnp4nagios'],
+    ],

[f.nicolaisen, 2017/10/25 10:01:12]

Hm, I accidentally included this change. I was working earlier with a version
that required the Exec above, but figured that the notify is sufficient.

[f.nicolaisen, 2017/10/25 14:36:09]

Acknowledged.

   }
 
   service {'apache2':