Issue 104 - added checktranslations function

localeTools.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import re
 import os
 import sys
 import codecs
 import json
 import urlparse
@@ skipping 295 matching lines @@
     base_path = localeConfig['base_path']
     for locale in os.listdir(base_path):
         jsonpath = os.path.join(base_path, locale, 'messages.json')
 
         if not os.path.exists(jsonpath):
             continue
 
         with codecs.open(jsonpath, 'rb', encoding='utf-8') as f:
             try:
                 data = json.load(f)
+                for key, value in data.iteritems():
+                    variables = set()
+                    max_length = value.get('maxLength')
+                    length = len(value['message'])
+                    if (max_length is not None and
+                            length > max_length or length > 160):
+                        print >>sys.stderr, (
+                            '{} {} -> translation might be too long.'
+                            'More then 160 chars or maxLength exceeded'
+                        ).format(locale, key)
+
+                    for match in re.finditer(r'\$(\S+?)\$', value['message']):
+                        variables.add(match.group(1))
+                    expected = set(value.get('placeholders', {}).iterkeys())
+                    if variables != expected:
+                        print >>sys.stderr, (
+                            '{} {}: Variables used are {} '
+                            'expected. Variables: {}'
+                        ).format(locale, key, variables, expected)
             except ValueError:
                 print >>sys.stderr, locale + ', messages.json is not valid.'
-
-        for key, value in data.iteritems():

[tlucas, 2017/11/13 12:23:51]

NOT LGTM, found a late error. sorry.

When a messages.json can not be read, but a previous messages.json was read
successfully, the following code is executed on the translations which were
already checked. 

You should do the additional checks inside the "try"-block above

[erick, 2017/11/20 11:41:09]

Done. tox and flake8 were fine, too.

-            variables = set()
-            max_length = value.get('maxLength')
-            length = len(value['message'])
-            if max_length is not None and length > max_length or length > 160:
-                print >>sys.stderr, (
-                    '{} {} -> translation might be too long. More then 160 '
-                    'chars or maxLength exceeded').format(locale, key)
-
-            for match in re.finditer(r'\$(\S+?)\$', value['message']):
-                variables.add(match.group(1))
-            expected = set(value.get('placeholders', {}).iterkeys())
-            if variables != expected:
-                print >>sys.stderr, (
-                    '{} {}: Variables used are {} '
-                    'expected. Variables: {}'
-                ).format(locale, key, variables, expected)