Issue 5142 - Convert Element Hiding to C++

compiled/bindings/main.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 16 matching lines @@
 #include "../filter/BlockingFilter.h"
 #include "../filter/WhitelistFilter.h"
 #include "../filter/ElemHideBase.h"
 #include "../filter/ElemHideFilter.h"
 #include "../filter/ElemHideException.h"
 #include "../filter/ElemHideEmulationFilter.h"
 #include "../subscription/Subscription.h"
 #include "../subscription/DownloadableSubscription.h"
 #include "../subscription/UserDefinedSubscription.h"
 #include "../storage/FilterStorage.h"
+#include "../ElemHide.h"
 #include "../FilterNotifier.h"
 
 int main()
 {
   try
   {
     class_<Filter>("Filter")
         .property("text", &Filter::GetText)
         .function("serialize", &Filter::Serialize)
         .class_function("fromText", &Filter::FromText)
@@ skipping 88 matching lines @@
 
     singleton<FilterStorage>("FilterStorage", &FilterStorage::GetInstance)
         .property("subscriptionCount", &FilterStorage::GetSubscriptionCount)
         .function("subscriptionAt", &FilterStorage::SubscriptionAt)
         .function("indexOfSubscription", &FilterStorage::IndexOfSubscription)
         .function("getSubscriptionForFilter", &FilterStorage::GetSubscriptionForFilter)
         .function("addSubscription", &FilterStorage::AddSubscription)
         .function("removeSubscription", &FilterStorage::RemoveSubscription)
         .function("moveSubscription", &FilterStorage::MoveSubscription);
 
+    class_<ElemHide_SelectorList>("ElemHide_SelectorList")
+        .property("selectorCount", &ElemHide_SelectorList::GetSelectorCount)
+        .function("selectorAt", &ElemHide_SelectorList::SelectorAt)
+        .function("filterKeyAt", &ElemHide_SelectorList::FilterKeyAt);
+
+    singleton<ElemHide>("ElemHide", &ElemHide::GetInstance)

[sergei, 2018/01/15 15:31:19]

Could you please change it from singleton to a class with the regular lifetime?

[hub, 2018/01/16 02:57:39]

I can. 

This require a few other changes, ElemHideEmulation (still in JS) to take and
ElemHide parameter, at least in this patch.

+        .function("add", &ElemHide::Add)
+        .function("remove", &ElemHide::Remove)
+        .function("clear", &ElemHide::Clear)
+        .function("getException", &ElemHide::GetException)
+        .function("getSelectorsForDomain", &ElemHide::GetSelectorsForDomain)
+        .function("getUnconditionalSelectors", &ElemHide::GetUnconditionalSelectors);
+
     printBindings();
     RegExpFilter::GenerateCustomBindings();
     FilterNotifier::GenerateCustomBindings();
 
     return 0;
   }
   catch (const std::exception& e)
   {
     EM_ASM_ARGS(
       console.error("Error occurred generating JavaScript bindings: " +
           Module.AsciiToString($0)), e.what()
     );
     return 1;
   }
 }