Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: lib/elemHideEmulation.js

Issue 29587914: Issue 5142 - Convert Element Hiding to C++ (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Left Patch Set: Add proper delete for filters in tests. Created Nov. 8, 2017, 12:02 a.m.
Right Patch Set: mFiltersByDomain is now an OwnedStringMap Created Jan. 26, 2018, 8:41 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Right: Side by side diff | Download
« no previous file with change/comment | « lib/elemHide.js ('k') | meson.build » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
(no file at all)
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 "use strict"; 18 "use strict";
19 19
20 /** 20 /**
21 * @fileOverview Element hiding emulation implementation. 21 * @fileOverview Element hiding emulation implementation.
22 */ 22 */
23 23
24 const {ElemHide} = require("elemHide");
25 const {Filter} = require("filterClasses"); 24 const {Filter} = require("filterClasses");
26 25
27 let filters = Object.create(null); 26 let filters = Object.create(null);
28 27
29 /** 28 /**
30 * Container for element hiding emulation filters 29 * Container for element hiding emulation filters
31 * @class 30 * @class
32 */ 31 */
33 let ElemHideEmulation = { 32 let ElemHideEmulation = {
34 /** 33 /**
(...skipping 18 matching lines...) Expand all
53 * @param {ElemHideEmulationFilter} filter 52 * @param {ElemHideEmulationFilter} filter
54 */ 53 */
55 remove(filter) 54 remove(filter)
56 { 55 {
57 delete filters[filter.text]; 56 delete filters[filter.text];
58 }, 57 },
59 58
60 /** 59 /**
61 * Returns a list of all rules active on a particular domain 60 * Returns a list of all rules active on a particular domain
62 * @param {string} domain 61 * @param {string} domain
62 * @param {Object} elemHide the ElemHide instance
63 * @return {ElemHideEmulationFilter[]} 63 * @return {ElemHideEmulationFilter[]}
64 */ 64 */
65 getRulesForDomain(domain) 65 getRulesForDomain(domain, elemHide)
66 { 66 {
67 let result = []; 67 let result = [];
68 let keys = Object.getOwnPropertyNames(filters); 68 let keys = Object.getOwnPropertyNames(filters);
69 for (let key of keys) 69 for (let key of keys)
70 { 70 {
71 let filter = Filter.fromText(key); 71 let filter = Filter.fromText(key);
72 if (filter.isActiveOnDomain(domain) && 72 if (filter.isActiveOnDomain(domain) &&
73 !ElemHide.getException(filter, domain)) 73 !elemHide.getException(filter, domain))
74 { 74 {
75 result.push(filter); 75 result.push(filter);
76 } 76 }
77 } 77 }
78 return result; 78 return result;
79 } 79 }
80 }; 80 };
81 exports.ElemHideEmulation = ElemHideEmulation; 81 exports.ElemHideEmulation = ElemHideEmulation;
LEFTRIGHT

Powered by Google App Engine
This is Rietveld