Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/elemHideEmulation.js

Issue 29587914: Issue 5142 - Convert Element Hiding to C++ (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Depend on #6279. Other minor fixes. Created Jan. 24, 2018, 2:24 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/elemHideEmulation.js
===================================================================
--- a/lib/elemHideEmulation.js
+++ b/lib/elemHideEmulation.js
@@ -16,17 +16,16 @@
*/
"use strict";
/**
* @fileOverview Element hiding emulation implementation.
*/
-const {ElemHide} = require("elemHide");
const {Filter} = require("filterClasses");
let filters = Object.create(null);
/**
* Container for element hiding emulation filters
* @class
*/
@@ -55,27 +54,28 @@
remove(filter)
{
delete filters[filter.text];
},
/**
* Returns a list of all rules active on a particular domain
* @param {string} domain
+ * @param {Object} elemHide the ElemHide instance
* @return {ElemHideEmulationFilter[]}
*/
- getRulesForDomain(domain)
+ getRulesForDomain(domain, elemHide)
sergei 2018/01/25 14:52:41 I wonder whether the order of parameters should be
hub 2018/01/25 16:55:09 Acknowledged.
{
let result = [];
let keys = Object.getOwnPropertyNames(filters);
for (let key of keys)
{
let filter = Filter.fromText(key);
if (filter.isActiveOnDomain(domain) &&
- !ElemHide.getException(filter, domain))
+ !elemHide.getException(filter, domain))
{
result.push(filter);
}
}
return result;
}
};
exports.ElemHideEmulation = ElemHideEmulation;

Powered by Google App Engine
This is Rietveld