OffTopic: DependencyUpdater

eyeo-depup/src/vcs.py

 # This file is part of Adblock Plus <https://adblockplus.org/>,
 # Copyright (C) 2006-present eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
@@ skipping 51 matching lines @@
         return self
 
     def __exit__(self, exc_type, exc_value, traceback):
         """Exit the object'c context and delete any temporary data."""
         if self._clean_up:
             shutil.rmtree(self._cwd)
 
     @classmethod
     def is_vcs_for_repo(cls, path):
         """Assert if cls is a suitable VCS for the given (repository-) path."""
-        return os.path.exists(os.path.join(path, cls.VCS_REQUIREMENT))
+        try:
+            subprocess.check_output([cls.EXECUTABLE, 'status'], cwd=path,
+                                    stderr=subprocess.STDOUT)
+            return True
+        except subprocess.CalledProcessError:
+            return False
 
     def run_cmd(self, *args, **kwargs):
         """Run the vcs with the given commands."""
         cmd = self.BASE_CMD + args
         try:
             return subprocess.check_output(
                 cmd,
                 cwd=os.path.join(self._cwd),
                 stderr=subprocess.STDOUT,
             ).decode('utf-8')
@@ skipping 100 matching lines @@
 
         if obj is None:
             raise Vcs.VcsException('No valid VCS found for ' + location)
         return obj
 
 
 class Mercurial(Vcs):
     """Mercurial specialization of VCS."""
 
     EXECUTABLE = 'hg'
-    VCS_REQUIREMENT = '.hg'
     BASE_CMD = (EXECUTABLE, '--config', 'defaults.log=', '--config',
                 'defaults.pull=', '--config', 'defaults.diff=')
     UPDATE_LOCAL_HISTORY = 'pull'
     LOG_TEMLATE = ('\\{"hash":"{node|short}","author":"{author|person}",'
                    '"date":"{date|rfc822date}","message":"{desc|strip|'
                    'firstline}"}\n')
     DEFAULT_NEW_REVISION = 'master'
 
     REVISION_URL = 'https://hg.adblockplus.org/{repository}/rev/{revision}'
 
@@ skipping 48 matching lines @@
     def repo_is_clean(self):
         """Check whether the current repository is clean."""
         buff = self.run_cmd('status')
         return len(buff) == 0
 
 
 class Git(Vcs):
     """Git specialization of Vcs."""
 
     EXECUTABLE = 'git'
-    VCS_REQUIREMENT = '.git'
     BASE_CMD = (EXECUTABLE,)
     UPDATE_LOCAL_HISTORY = 'fetch'
     LOG_TEMLATE = '{"hash":"%h","author":"%an","date":"%aD","message":"%s"}'
     DEFAULT_NEW_REVISION = 'origin/master'
 
     REVISION_URL = ('https://www.github.com/adblockplus/{repository}/commit/'
                     '{revision}')
 
     def __init__(self, *args):
         """Construct a Git object and specify Mercurial as the mirror class."""
@@ skipping 42 matching lines @@
         self.run_cmd('checkout', '.')
 
     def repo_is_clean(self):
         """Check whether the current repository is clean."""
         # unstaged changes
         no_uncommited = len(self.run_cmd('diff-index', 'HEAD', '--')) == 0
         # untracked changes
         no_untracked = len(self.run_cmd('ls-files', '-o', '-d',
                                         '--exclude-standard')) == 0
         return no_uncommited and no_untracked