Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: compiled/filter/ElemHideBase.h

Issue 29600641: Issue 5175 - Reject element hiding filter with empty domain names (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Created Nov. 7, 2017, 11:17 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « compiled/filter/ActiveFilter.cpp ('k') | compiled/filter/ElemHideBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiled/filter/ElemHideBase.h
===================================================================
--- a/compiled/filter/ElemHideBase.h
+++ b/compiled/filter/ElemHideBase.h
@@ -54,18 +54,20 @@
};
class ElemHideBase : public ActiveFilter
{
protected:
ElemHideData mData;
public:
static constexpr Type classType = Type::ELEMHIDEBASE;
- explicit ElemHideBase(Type type, const String& text, const ElemHideData& data);
- static Type Parse(DependentString& text, ElemHideData& data);
+ explicit ElemHideBase(Type type, const String& text, const ElemHideData& data,
+ const ParsedDomains& parsedDomains);
+ static Type Parse(DependentString& text, DependentString& error,
+ ElemHideData& data, ParsedDomains& parsedDomains);
const DependentString BINDINGS_EXPORTED GetSelector() const
{
return mData.GetSelector(mText);
}
OwnedString BINDINGS_EXPORTED GetSelectorDomain() const;
};
« no previous file with comments | « compiled/filter/ActiveFilter.cpp ('k') | compiled/filter/ElemHideBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld