Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: static/scss/main.scss

Issue 29603821: Noissue - Separated website-default utilities (Closed) Base URL: https://hg.adblockplus.org/website-defaults
Left Patch Set: Rebased and re-separated Created Dec. 6, 2017, 3:55 p.m.
Right Patch Set: Addressed comments #13 Created Dec. 14, 2017, 1:36 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « static/scss/_utilities.scss ('k') | static/scss/utilities/_colors.scss » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /*! 1 /*!
2 * This file is part of website-defaults 2 * This file is part of website-defaults
3 * Copyright (C) 2016-present eyeo GmbH 3 * Copyright (C) 2016-present eyeo GmbH
4 * 4 *
5 * website-defaults is free software: you can redistribute it and/or 5 * website-defaults is free software: you can redistribute it and/or
6 * modify it under the terms of the GNU General Public License as published by 6 * modify it under the terms of the GNU General Public License as published by
7 * the Free Software Foundation, either version 3 of the License, or 7 * the Free Software Foundation, either version 3 of the License, or
8 * (at your option) any later version. 8 * (at your option) any later version.
9 * 9 *
10 * website-defaults is distributed in the hope that it will be useful, 10 * website-defaults is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of 11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 * GNU General Public License for more details. 13 * GNU General Public License for more details.
14 * 14 *
15 * You should have received a copy of the GNU General Public License 15 * You should have received a copy of the GNU General Public License
16 * along with website-defaults. If not, see <http://www.gnu.org/licenses/>. 16 * along with website-defaults. If not, see <http://www.gnu.org/licenses/>.
17 */ 17 */
18 18
19 @import "variables"; 19 @import "variables";
20 @import "utilities/overrides.scss";
21 @import "utilities/colors.scss";
22 @import "utilities/layout.scss";
23 @import "utilities/text.scss";
24 @import "utilities/widths.scss";
20 @import "reset"; 25 @import "reset";
21 @import "base"; 26 @import "base";
22 @import "content"; 27 @import "content";
23 @import "grid"; 28 @import "grid";
24 @import "forms/basic"; 29 @import "forms/basic";
25 @import "forms/advanced"; 30 @import "forms/advanced";
26 @import "forms/buttons"; 31 @import "forms/buttons";
27 @import "utilities/responsive-widths.scss";
ire 2017/12/07 11:44:20 I think utilities should come earlier (after reset
juliandoucette 2017/12/07 12:33:57 They ( are / can be ) extended ( in / by ) imports
ire 2017/12/11 15:44:03 You didn't move them?
juliandoucette 2017/12/14 13:37:07 oops. Done.
28 @import "utilities/fixed-widths.scss";
ire 2017/12/07 11:44:20 NIT: I think some of these categories are a bit to
juliandoucette 2017/12/07 12:33:57 Agreed.
juliandoucette 2017/12/08 16:11:06 Done.
29 @import "utilities/floats.scss";
30 @import "utilities/clearfix.scss";
31 @import "utilities/background-colors.scss";
32 @import "utilities/text-alignment.scss";
33 @import "utilities/unstyled.scss";
34 @import "utilities/screen-reader.scss";
LEFTRIGHT

Powered by Google App Engine
This is Rietveld