Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/options.js

Issue 29604555: Issue 5965 - Handle edge case when searching for options page tab (Closed)
Patch Set: Created Nov. 11, 2017, 4:36 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/options.js
diff --git a/lib/options.js b/lib/options.js
index fa39d78374b04df576ddc85aedd5aea613fffe39..84adf19cc27921e40322c25e45135b3acadb3c66 100644
--- a/lib/options.js
+++ b/lib/options.js
@@ -38,7 +38,52 @@ function findOptionsTab(callback)
// starting with Firefox 56 an extension can query for its own URLs:
// https://bugzilla.mozilla.org/show_bug.cgi?id=1271354
let fullOptionsUrl = browser.extension.getURL(optionsUrl);
- callback(tabs.find(element => element.url == fullOptionsUrl));
+ let optionsTab = tabs.find(tab => tab.url == fullOptionsUrl);
+
+ if (optionsTab)
+ callback(optionsTab);
+ else
+ {
+ // It seems that the url property isn't always set for the tab with
+ // Firefox 57 on Windows 10 until the tab has finished loading. Until
+ // then the url is given as "about:blank", but the title is the URL
+ // we expect (minus the protocol part).
+ let {hostname, pathname} = new URL(fullOptionsUrl);
+ let potentialOptionsTab = tabs.find(
+ tab => tab.url == "about:blank" &&
+ tab.title == hostname + pathname &&
+ tab.status == "loading"
+ );
+
+ if (potentialOptionsTab)
+ {
+ let onRemoved;
+ let updateListener = (tabId, changeInfo, tab) =>
+ {
+ if (tabId == potentialOptionsTab.id &&
+ changeInfo.status == "complete")
+ {
+ browser.tabs.onUpdated.removeListener(updateListener);
+ browser.tabs.onRemoved.removeListener(onRemoved);
+ if (tab.url == fullOptionsUrl)
+ callback(tab);
+ }
+ };
+ browser.tabs.onUpdated.addListener(updateListener);
+ onRemoved = removedTabId =>
+ {
+ if (removedTabId == potentialOptionsTab.id)
+ {
+ browser.tabs.onUpdated.removeListener(updateListener);
+ browser.tabs.onRemoved.removeListener(onRemoved);
+ callback();
+ }
+ };
+ browser.tabs.onRemoved.addListener(onRemoved);
+ }
+ else
+ callback();
+ }
});
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld