Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: skin/desktop-options.css

Issue 29609587: Issue 6031 - Implement Acceptable Ads notification (Closed)
Patch Set: Created Nov. 15, 2017, 5:01 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 602 matching lines...) Expand 10 before | Expand all | Expand 10 after
613 613
614 section.cols > *:last-child 614 section.cols > *:last-child
615 { 615 {
616 flex: 3; 616 flex: 3;
617 } 617 }
618 618
619 /* 619 /*
620 Acceptable ads 620 Acceptable ads
621 */ 621 */
622 622
623 #acceptable-ads.show-notification #tracking-notification
Thomas Greiner 2017/11/16 19:25:06 Suggestion: You could avoid setting "display" twic
saroyanm 2017/11/17 16:10:39 Right, done.
624 {
625 display: block;
626 }
627
628 #tracking-notification
629 {
630 position: relative;
631 display: none;
632 padding: 1.5rem;
633 margin-bottom: 1rem;
634 border: 2px solid #ffd7a3;
635 background-color: #fefbe3;
Thomas Greiner 2017/11/16 19:25:05 Detail: These colors aren't mentioned in the style
saroyanm 2017/11/17 16:10:39 Yes in general style guide for this notification i
Thomas Greiner 2017/11/20 18:36:04 Acknowledged.
636 }
637
638 #hide-tracking-notification
639 {
640 position: absolute;
641 right: 1rem;
Thomas Greiner 2017/11/16 19:25:06 What about right-to-left environments?
saroyanm 2017/11/17 16:10:39 Done.
642 top: 1rem;
643 }
644
645 #tracking-notification .link
Thomas Greiner 2017/11/16 19:25:06 Detail: Links also use `cursor: pointer`. Alterna
saroyanm 2017/11/17 16:10:39 `cursor: pointer` is inherited from the class `but
Thomas Greiner 2017/11/20 18:36:04 Indeed, I missed that.
646 {
647 color: inherit;
648 text-decoration: underline;
649 font-weight: 700;
650 }
651
623 #acceptable-ads ul 652 #acceptable-ads ul
624 { 653 {
625 position: relative; 654 position: relative;
626 padding-left: 2rem; 655 padding-left: 2rem;
627 list-style: none; 656 list-style: none;
628 } 657 }
629 658
630 html[dir="rtl"] #acceptable-ads ul 659 html[dir="rtl"] #acceptable-ads ul
631 { 660 {
632 padding-left: 0rem; 661 padding-left: 0rem;
633 padding-right: 2rem; 662 padding-right: 2rem;
634 } 663 }
635 664
636 #acceptable-ads button 665 #acceptable-ads ul button
637 { 666 {
638 position: absolute; 667 position: absolute;
639 margin-top: 0.3rem; 668 margin-top: 0.3rem;
640 left: 0rem; 669 left: 0rem;
641 } 670 }
642 671
643 html[dir="rtl"] button 672 html[dir="rtl"] button
644 { 673 {
645 left: auto; 674 left: auto;
646 right: 0rem; 675 right: 0rem;
(...skipping 253 matching lines...) Expand 10 before | Expand all | Expand 10 after
900 .tooltip::before 929 .tooltip::before
901 { 930 {
902 content: ""; 931 content: "";
903 width: 1.3rem; 932 width: 1.3rem;
904 height: 1.3rem; 933 height: 1.3rem;
905 display: block; 934 display: block;
906 background-image: url(icons/tooltip.svg); 935 background-image: url(icons/tooltip.svg);
907 } 936 }
908 937
909 /* 938 /*
910 Used for translatable screen reader only conten. 939 Used for translatable screen reader only conten.
Thomas Greiner 2017/11/16 19:25:06 Typo: Replace "conten" with "content".
saroyanm 2017/11/17 16:10:39 Done.
911 e.g.: Use instead of aria-label to avoid complex attribute value translation 940 e.g.: Use instead of aria-label to avoid complex attribute value translation
912 */ 941 */
913 .sr-only 942 .sr-only
914 { 943 {
915 position: absolute; 944 position: absolute;
916 overflow: hidden; 945 overflow: hidden;
917 clip: rect(0, 0, 0, 0); 946 clip: rect(0, 0, 0, 0);
918 width: 1px; 947 width: 1px;
919 height: 1px; 948 height: 1px;
920 margin: -1px; 949 margin: -1px;
(...skipping 369 matching lines...) Expand 10 before | Expand all | Expand 10 after
1290 } 1319 }
1291 1320
1292 #dialog header h3 1321 #dialog header h3
1293 { 1322 {
1294 margin: 0rem; 1323 margin: 0rem;
1295 font-size: 1.375rem; 1324 font-size: 1.375rem;
1296 font-weight: 700; 1325 font-weight: 700;
1297 } 1326 }
1298 1327
1299 #dialog-close, 1328 #dialog-close,
1300 #hide-notification 1329 #hide-notification,
1330 #hide-tracking-notification
1301 { 1331 {
1302 border: 0rem; 1332 border: 0rem;
1303 padding: 0rem; 1333 padding: 0rem;
1304 margin: 0rem; 1334 margin: 0rem;
1305 background-color: transparent; 1335 background-color: transparent;
1306 cursor: pointer; 1336 cursor: pointer;
1307 } 1337 }
1308 1338
1309 #dialog-close::before, 1339 #dialog-close::before,
1310 #hide-notification::after 1340 #hide-notification::after,
1341 #hide-tracking-notification::after
1311 { 1342 {
1312 content: ""; 1343 content: "";
1313 display: block; 1344 display: block;
1314 height: 1rem; 1345 height: 1rem;
1315 width: 1rem; 1346 width: 1rem;
1316 border: 0rem; 1347 border: 0rem;
1317 background-image: url(icons/delete.svg#primary); 1348 background-image: url(icons/delete.svg#primary);
1318 } 1349 }
1319 1350
1320 #dialog-close:hover::before 1351 #dialog-close:hover::before
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
1437 #hide-notification 1468 #hide-notification
1438 { 1469 {
1439 margin: 0rem 1rem; 1470 margin: 0rem 1rem;
1440 } 1471 }
1441 1472
1442 #hide-notification::after 1473 #hide-notification::after
1443 { 1474 {
1444 background-image: url(icons/delete.svg#secondary); 1475 background-image: url(icons/delete.svg#secondary);
1445 } 1476 }
1446 1477
1478 #hide-tracking-notification::after
1479 {
1480 background-image: url(icons/delete.svg#tertiary);
1481 }
1482
1447 #hide-notification:hover::after 1483 #hide-notification:hover::after
1448 { 1484 {
1449 background-image: url(icons/delete.svg#secondary-hover); 1485 background-image: url(icons/delete.svg#secondary-hover);
1450 } 1486 }
1487
1488 #hide-tracking-notification:hover::after
1489 {
1490 background-image: url(icons/delete.svg#tertiary-hover);
1491 }
OLDNEW

Powered by Google App Engine
This is Rietveld