Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: desktop-options.html

Issue 29609587: Issue 6031 - Implement Acceptable Ads notification (Closed)
Left Patch Set: Addressed Thomas comments Created Nov. 17, 2017, 4:03 p.m.
Right Patch Set: Created Nov. 21, 2017, 6:15 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « background.js ('k') | desktop-options.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <https://adblockplus.org/>, 3 - This file is part of Adblock Plus <https://adblockplus.org/>,
4 - Copyright (C) 2006-present eyeo GmbH 4 - Copyright (C) 2006-present eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 <h2 class="i18n_options_acceptableAds_header"></h2> 96 <h2 class="i18n_options_acceptableAds_header"></h2>
97 <p class="i18n_options_acceptableAds_description"></p> 97 <p class="i18n_options_acceptableAds_description"></p>
98 </header> 98 </header>
99 <form id="acceptable-ads"> 99 <form id="acceptable-ads">
100 <div id="tracking-warning"> 100 <div id="tracking-warning">
101 <button id="hide-tracking-warning" type="button" data-pref="ui_war n_tracking" data-action="toggle-pref"> 101 <button id="hide-tracking-warning" type="button" data-pref="ui_war n_tracking" data-action="toggle-pref">
102 <span class="i18n_options_notification_hide sr-only"></span> 102 <span class="i18n_options_notification_hide sr-only"></span>
103 </button> 103 </button>
104 <p id="tracking-warning-1"></p> 104 <p id="tracking-warning-1"></p>
105 <p class="i18n_options_tracking_warning_2"></p> 105 <p class="i18n_options_tracking_warning_2"></p>
106 <p id="tracking-warning-3" class="i18n_options_tracking_warning_3" ></p> 106 <p id="tracking-warning-3"></p>
Thomas Greiner 2017/11/20 18:36:04 Detail: The "i18n_*" class here is redundant becau
saroyanm 2017/11/21 14:58:32 Done.
107 <button class="i18n_options_tracking_warning_acknowledgment link" type="button" data-pref="ui_warn_tracking" data-action="toggle-pref"></button> 107 <button class="i18n_options_tracking_warning_acknowledgment link" type="button" data-pref="ui_warn_tracking" data-action="toggle-pref"></button>
108 </div> 108 </div>
109 <ul> 109 <ul>
110 <li> 110 <li>
111 <button id="acceptable-ads-allow" data-action="switch-acceptable -ads" type="button" role="checkbox" name="acceptable-ads" value="ads"></button> 111 <button id="acceptable-ads-allow" data-action="switch-acceptable -ads" type="button" role="checkbox" name="acceptable-ads" value="ads"></button>
112 <label for="acceptable-ads-allow" class="i18n_options_acceptable Ads_ads_label"></label> 112 <label for="acceptable-ads-allow" class="i18n_options_acceptable Ads_ads_label"></label>
113 <p id="enable-acceptable-ads-description" class="i18n_options_ac ceptableAds_ads_description_1"></p> 113 <p id="enable-acceptable-ads-description" class="i18n_options_ac ceptableAds_ads_description_1"></p>
114 </li> 114 </li>
115 <ul> 115 <ul>
116 <li> 116 <li>
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
418 </div> 418 </div>
419 <!-- Notification --> 419 <!-- Notification -->
420 <div id="notification" aria-hidden="true" aria-live="polite"> 420 <div id="notification" aria-hidden="true" aria-live="polite">
421 <strong id="notification-text"></strong> 421 <strong id="notification-text"></strong>
422 <button id="hide-notification" data-action="hide-notification"> 422 <button id="hide-notification" data-action="hide-notification">
423 <span class="i18n_options_notification_hide sr-only"></span> 423 <span class="i18n_options_notification_hide sr-only"></span>
424 </button> 424 </button>
425 </div> 425 </div>
426 </body> 426 </body>
427 </html> 427 </html>
LEFTRIGHT

Powered by Google App Engine
This is Rietveld