Issue 6064 - Put C++ code into a configurable namespace

compiled/bindings/generator.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <cstdio>
 
 #include "generator.h"
 #include "library.h"
 
+ABP_NS_USING
+
 namespace
 {
   std::vector<bindings_internal::ClassInfo> classes;
 }
-
+ABP_NS_BEGIN

[hub, 2017/11/21 16:48:39]

the anonymous namespace above should be within this namespace.

[sergei, 2017/11/22 09:39:26]

Here this anonymous namespace can be in ABP_NS namespace but in general I am not
sure that we should make it so strict because in this case one will have to use
`ABP_NS::` prefix sometimes in order to get access to things declared in the
ABP_NS::<unnamed_namespace> what can be rather annoying and even confusing
because there is already ABP_NS_USING. Do you mind to generally not put
anonymous namespaces already residing in our translation unit into ABP_NS if
there is no conflict?

 namespace bindings_internal
 {
   FunctionInfo::FunctionInfo()
   {
   }
 
   FunctionInfo::FunctionInfo(TypeCategory returnType, TYPEID pointerType,
       std::initializer_list<TypeCategory> argTypes, bool instance_function,
       void* function)
       : returnType(returnType), pointerType(pointerType),
@@ skipping 432 matching lines @@
       DifferentiatorInfo differentiator = cls.subclass_differentiator;
       if (differentiator.offset == SIZE_MAX)
         return;
 
       printf("var %s_mapping = \n", cls.name.c_str());
       puts("{");
       for (const auto& item : differentiator.mapping)
         printf("  %i: exports.%s,\n", item.first, item.second.c_str());
       puts("};");
   }
-}
+} // namespace bindings_internal
 
 void printBindings()
 {
   bindings_internal::printHelpers();
 
   for (const auto& cls : classes)
     bindings_internal::printClass(cls);
   for (const auto& cls : classes)
     bindings_internal::printClassMapping(cls);
 }
+
+ABP_NS_END