 Issue 29613616:
  Issue 6064 - Put C++ code into a configurable namespace  (Closed) 
  Base URL: https://github.com/adblockplus/adblockpluscore.git
    
  
    Issue 29613616:
  Issue 6064 - Put C++ code into a configurable namespace  (Closed) 
  Base URL: https://github.com/adblockplus/adblockpluscore.git
| Left: | ||
| Right: | 
| OLD | NEW | 
|---|---|
| 1 /* | 1 /* | 
| 2 * This file is part of Adblock Plus <https://adblockplus.org/>, | 2 * This file is part of Adblock Plus <https://adblockplus.org/>, | 
| 3 * Copyright (C) 2006-present eyeo GmbH | 3 * Copyright (C) 2006-present eyeo GmbH | 
| 4 * | 4 * | 
| 5 * Adblock Plus is free software: you can redistribute it and/or modify | 5 * Adblock Plus is free software: you can redistribute it and/or modify | 
| 6 * it under the terms of the GNU General Public License version 3 as | 6 * it under the terms of the GNU General Public License version 3 as | 
| 7 * published by the Free Software Foundation. | 7 * published by the Free Software Foundation. | 
| 8 * | 8 * | 
| 9 * Adblock Plus is distributed in the hope that it will be useful, | 9 * Adblock Plus is distributed in the hope that it will be useful, | 
| 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of | 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of | 
| 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | 
| 12 * GNU General Public License for more details. | 12 * GNU General Public License for more details. | 
| 13 * | 13 * | 
| 14 * You should have received a copy of the GNU General Public License | 14 * You should have received a copy of the GNU General Public License | 
| 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. | 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. | 
| 16 */ | 16 */ | 
| 17 | 17 | 
| 18 #include "ElemHideEmulationFilter.h" | 18 #include "ElemHideEmulationFilter.h" | 
| 19 | 19 | 
| 20 ABP_NS_USING | |
| 
hub
2017/11/21 16:48:39
This should be ABP_NS_BEGIN
(and have the matching
 
sergei
2017/11/22 09:39:27
Could you please explain the advantage of wrapping
 | |
| 21 | |
| 20 ElemHideEmulationFilter::ElemHideEmulationFilter(const String& text, | 22 ElemHideEmulationFilter::ElemHideEmulationFilter(const String& text, | 
| 21 const ElemHideData& data) | 23 const ElemHideData& data) | 
| 22 : ElemHideBase(Type::ELEMHIDEEMULATION, text, data) | 24 : ElemHideBase(Type::ELEMHIDEEMULATION, text, data) | 
| 23 { | 25 { | 
| 24 } | 26 } | 
| OLD | NEW |