Issue 6064 - Put C++ code into a configurable namespace

compiled/StringMap.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #pragma once
 
 #include <cstddef>
 
+#include "base.h"
 #include "Map.h"
 #include "String.h"
 
-namespace {
-  size_t stringHash(const String& key)
+ABP_NS_BEGIN
+namespace StringMap_internal

[sergei, 2018/02/06 10:03:17]

here is actually an unrelated change, we are normally not using anonymous
namespaces in headers. Please let me know if it is worth a separate commit.

+{
+  inline size_t stringHash(const String& key)
   {
     // FNV-1a hash function
     size_t result = 2166136261;
     for (size_t i = 0; i < key.length(); i++)
       result = (result ^ key[i]) * 16777619;
     return result;
   }
 }
 
 struct StringHash
 {
   size_t operator()(const String& key) const
   {
-    return stringHash(key);
+    return StringMap_internal::stringHash(key);
   }
 };
 
 namespace StringMap_internal
 {
   template<typename Key,
     class = typename std::enable_if<std::is_base_of<String, Key>::value>::type>
   struct StringSetEntry
   {
     typedef Key key_type;
@@ skipping 55 matching lines @@
     }
   };
 }
 
 using StringSet = Set<StringMap_internal::StringSetEntry<DependentString>>;
 
 template<typename Value>
 using StringMap = Map<StringMap_internal::StringMapEntry<DependentString, Value>>;
 template<typename Value>
 using OwnedStringMap = Map<StringMap_internal::StringMapEntry<OwnedString, Value>>;
+ABP_NS_END