Issue 6064 - Put C++ code into a configurable namespace

compiled/base.h

Index: compiled/base.h
diff --git a/compiled/bindings/runtime.h b/compiled/base.h
similarity index 68%
copy from compiled/bindings/runtime.h
copy to compiled/base.h
index 549eeef479e5ace136c078f942008c21b98f1734..10a9f0022862e579446f50f15e3ff3868c5f0077 100644
--- a/compiled/bindings/runtime.h
+++ b/compiled/base.h
@@ -12,14 +12,16 @@
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
- * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+ * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
  */
 
 #pragma once
 
-#if defined(__EMSCRIPTEN__)
-#include <emscripten.h>
-#define BINDINGS_EXPORTED EMSCRIPTEN_KEEPALIVE
-#else
-#define BINDINGS_EXPORTED
+// if a user config is not specified then use the default location.
+#if !defined(ABP_USER_CONFIG)
+#  define ABP_USER_CONFIG "user.h"

[hub, 2017/11/21 16:48:39]

I would call this "user-config.h". and the present header config.h instead of
base.h.

We could also consider having it generated from the build system.

But this is just my suggestion.

Also I would just have the content of "user.h" here if ABP_USER_CONFIG is
undefined.

[sergei, 2017/11/22 09:39:26]

I like to have config.h with a more specific part user-config.h which is also
close to ABP_USER_CONFIG. I actually thought about config/user.h and just
omitted 'config' for the sake of simplicity.
I have renamed user.h to user-config.h.

What concerns base.h, I considered it as not only a place for configuration. For
instance base.h could also include some additional very common headers or have
some project specific defines. So, when we need it in my opinion we should not
go again through all relevant files and change config.h to some base.h.
Therefore I would propose to have
base.h
  include config.h
    include user-config.h
but currently having both config.h and base.h seems redundant, so I would
propose to not complicate it for present, it will be very easy to add config.h
when it's really needed. What do you think about it?
The idea is that one can simply copy user-config.h and adjust few parameters, if
it is inlined then one will have to firstly figure out what should be in a
custom user-config.h. So, IMO it should not be inlined.

+#endif
+// it should be the first included file
+#ifdef ABP_USER_CONFIG
+#include ABP_USER_CONFIG
 #endif