Issue 6090 - Properly use regexp for message matching and proper console override

test/_common.js

Index: test/_common.js
===================================================================
--- a/test/_common.js
+++ b/test/_common.js
@@ -86,20 +86,16 @@
         return {[resourceName]: resources[resourceName]};
 
       throw new Error(
         "Attempt to import unknown JavaScript module " + resource
       );
     },
     reportError(e) {}
   },
-  console: {
-    log: console.log.bind(console),
-    error: console.error.bind(console)
-  },
   navigator: {
   },
   onShutdown: {
     add() {}
   },
   URL
 };
 
@@ -416,48 +412,49 @@
     }
   };
 };
 
 console.warn = console.log;
 
 exports.silenceWarnOutput = function(test, msg)
 {
-  let warnHandler = globals.console.warn;
-  globals.console.warn = s =>
+  let warnHandler = console.warn;
+  console.warn = s =>
   {
     if (s != msg)
       warnHandler(s);
   };
   try
   {
     return test();
   }
   finally
   {
-    globals.console.warn = warnHandler;
+    console.warn = warnHandler;
   }
 };
 
 exports.silenceAssertionOutput = function(test, msg)
 {
-  let msgMatch = new RegExp(`^Error: ${msg}[\r\n]`);
-  let errorHandler = globals.console.error;
-  globals.console.error = s =>
+  let msgMatch = new RegExp("^Error: (.*)[\r\n]");
+  let errorHandler = console.error;
+  console.error = s =>

[sergei, 2017/11/28 15:46:22]

should not we wrap even a single argument of the lambdas (also above) in
parentheses? `(s) => ...`

[hub, 2017/11/28 15:54:20]

This follow our code style.

   {
-    if (!msgMatch.test(s))
+    let match = msgMatch.match(s);

[sergei, 2017/11/28 15:46:22]

AFAIR regexp does not have method `match`, it should be either msgMatch.exec or
s.match(msgMatch), IMO the former is better.

[hub, 2017/11/28 15:54:20]

Already fixed in the patch update. I have no idea how I didn't catch it prior to
submission :-/

+    if (!match || match[1] != msg)
       errorHandler(s);
   };
   try
   {
     return test();
   }
   finally
   {
-    globals.console.error = errorHandler;
+    console.error = errorHandler;
   }
 };
 
 exports.setupRandomResult = function()
 {
   let randomResult = 0.5;
   Object.defineProperty(this, "randomResult", {
     get: () => randomResult,