Unified Diff: index.html
Issue 29646555:
Issue 6210 - Implement Subscription (Double-opt-in) template for newsletter (Closed)
Patch Set: Update hgignore
Created Dec. 21, 2017, 11:50 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« img/abp-logo.svg ('k')
|
package.json » ('j')
|
scss/_content.scss » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: index.html |
| =================================================================== |
| new file mode 100644 |
| --- /dev/null |
| +++ b/index.html |
| @@ -0,0 +1,39 @@ |
| +<!doctype html> |
| +<html lang="en" dir="ltr"> |
|
saroyanm
2017/12/21 16:07:58
I assume we only planing to have English version r
juliandoucette
2017/12/21 22:06:51
(I think the implication here is that we don't nee
ire
2017/12/22 10:33:25
I also believe that we're only having an English v
juliandoucette
2017/12/22 13:32:22
In that case I agree that we should keep both of t
|
| +<head> |
| + <meta charset="utf-8"> |
|
saroyanm
2017/12/21 16:07:58
There is also a meta description provided in the s
ire
2017/12/22 10:33:25
It should be here as well, I will add that now.
ire
2017/12/22 10:33:25
Done.
|
| + <title>Adblock Plus newsletter signup form</title> |
|
juliandoucette
2017/12/21 22:06:51
Also I think this should be "Newsletter Signup | A
juliandoucette
2017/12/21 22:06:51
Do we know whether or not search engines and socia
ire
2017/12/22 10:33:23
I don't know about this.
If so, we should conside
ire
2017/12/22 10:33:23
Could you make a comment in the Specification abou
juliandoucette
2017/12/22 13:32:22
Yes.
|
| + <meta name="viewport" content="width=device-width, initial-scale=1"> |
| + <link rel="stylesheet" type="text/css" href="css/main.min.css"> |
|
juliandoucette
2017/12/21 22:06:50
[Separate, minified] css seems like overkill here.
ire
2017/12/22 10:33:25
(I mentioned in a separate comment) that my plan i
juliandoucette
2017/12/22 13:32:22
I don't think that this little amount of CSS will
|
| +</head> |
| +<body> |
| + <div class="outer-container"> |
| + <div class="container phablet-width content"> |
| + |
| + <header id="header"> |
| + <h1 id="title"> |
|
juliandoucette
2017/12/21 22:06:51
"title" has a specific meaning in HTM. Did you cho
ire
2017/12/22 10:33:23
I chose #title and #header simply because its esse
juliandoucette
2017/12/22 13:32:22
Ack. Yes.
|
| + <img src="img/abp-logo.png" srcset="img/abp-logo.svg 2x" alt="ABP inside red octagon"> |
| + <span>Adblock<strong>Plus</strong></span> |
|
saroyanm
2017/12/21 16:07:58
Suggestion/detail: we might want to separate the w
juliandoucette
2017/12/21 22:06:51
I think we should follow in adblockplus.org's exam
ire
2017/12/22 10:33:23
Done.
ire
2017/12/22 10:33:25
Done.
|
| + </h1> |
| + <p class="lead"><strong>Sign up for the Adblock Plus newsletter</strong></p> |
|
saroyanm
2017/12/21 16:07:58
Detail: According to the specs it's a Heading, not
juliandoucette
2017/12/21 22:06:51
I kinda see where she's coming from... (I've gone
ire
2017/12/22 10:33:24
Done.
ire
2017/12/22 10:33:24
Done.
|
| + <p>Stay up to date with all things Adblock Plus</p> |
| + </header> |
| + |
| + <form class="phone-width align-center"> |
|
saroyanm
2017/12/21 16:07:57
I'll sugget to assign styles to the form itself ra
juliandoucette
2017/12/21 22:06:51
NIT/TOL: The use of these device widths seems to b
ire
2017/12/22 10:33:24
I'm not sure I understand what you mean. Do you th
ire
2017/12/22 10:33:24
Done.
|
| + <label for="email">Email Address *</label> |
| + <input type="email" id="email" name="email" required> |
| + <span class="error-message">Please enter a valid email address</span> |
|
saroyanm
2017/12/21 16:07:58
Specs need clarification: it's not obvious whether
saroyanm
2017/12/21 16:07:58
I assume you would like to figure out first how va
ire
2017/12/22 10:33:22
Yes I will be using Backclick's method for validat
ire
2017/12/22 10:33:26
I think according to the spec, it should happen be
saroyanm
2017/12/22 12:26:11
I agree.
juliandoucette
2017/12/22 13:32:23
Please point this out in the spec.
|
| + |
| + <label for="fullname">Full name</label> |
| + <input type="text" id="fullname" name="fullname"> |
| + |
| + <button type="submit" class="button secondary">Sign Up</button> |
|
saroyanm
2017/12/21 16:07:58
Might be irrelevant while you check how backclick
ire
2017/12/22 10:33:25
Yes. As I mentioned in my comment above, in order
juliandoucette
2017/12/22 13:32:22
Again, please point this out in the spec.
|
| + |
| + <p class="text-center"> |
|
saroyanm
2017/12/21 16:07:58
Detail: According to the specification the text is
juliandoucette
2017/12/21 22:06:50
NIT: I think that this should be inside a <footer>
ire
2017/12/22 10:33:24
Done.
ire
2017/12/22 10:33:25
Done.
|
| + <a href="https://adblockplus.org/en/privacy" target="_blank">Privacy Policy</a> |
|
saroyanm
2017/12/21 16:07:57
I assume we are planing to update the privacy poli
ire
2017/12/22 10:33:25
I'm not sure about this. I will post this comment
ire
2017/12/22 11:46:28
See comment here https://issues.adblockplus.org/ti
juliandoucette
2017/12/22 13:32:22
Acknowledged.
|
| + </p> |
| + </form> |
| + </div> |
| + </div> |
| +</body> |
| +</html> |
« no previous file with comments
|
« img/abp-logo.svg ('k')
|
package.json » ('j')
|
scss/_content.scss » ('J')
