Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/prefs.js

Issue 29664623: Issue 6403 - Updated adblockplusui dependency (Closed)
Patch Set: Created Jan. 12, 2018, 4:26 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/prefs.js
===================================================================
--- a/lib/prefs.js
+++ b/lib/prefs.js
@@ -201,6 +201,14 @@
defaults.additional_subscriptions = [];
/**
+ * The version of major updates that the user is aware of. If it's too low,
Thomas Greiner 2018/01/12 16:33:39 I'm aware that "version of major updates" might so
kzar 2018/01/15 11:58:35 How about something like this? "With some major re
Thomas Greiner 2018/01/17 18:00:05 Problem is it doesn't reflect the "most recent ver
+ * the updates page will be shown to inform the user about intermediate changes.
+ *
+ * @type {number}
+ */
+defaults.lastUpdatesVersion = 0;
kzar 2018/01/15 11:58:35 Other preferences names seem to mostly use snake c
kzar 2018/01/15 11:58:35 I guess the default value should be "0.0.0" with m
Thomas Greiner 2018/01/17 18:00:06 It'd be great if we could make those consistent in
Thomas Greiner 2018/01/17 18:00:06 Yep, it would need to be. Let's come back to this
+
+/**
* @namespace
* @static
*/
« no previous file with comments | « dependencies ('k') | lib/subscriptionInit.js » ('j') | lib/subscriptionInit.js » ('J')

Powered by Google App Engine
This is Rietveld