Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngineProvider.java

Issue 29671734: Issue 6265 - Create shared AdblockEngine instance in AdblockWebView in background (Closed)
Patch Set: Created Jan. 17, 2018, 11:48 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH
4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation.
8 *
9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details.
13 *
14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */
17
18 package org.adblockplus.libadblockplus.android;
19
20 public interface AdblockEngineProvider
21 {
22 /**
23 * Register AdblockEngine client
24 * @param asynchronous If `true` engines will be created in background thread without locking of
25 * current thread. Use waitForReady() before getEngine() l ater.
26 * If `false` locks current thread.
27 * @return if a new instance is allocated
sergei 2018/01/19 13:56:41 Is it actually required to know that a new instanc
anton 2018/01/22 06:17:37 Yes, in AdblockChromium we need to know it to send
28 */
29 boolean retain(boolean asynchronous);
30
31 /**
32 * Wait until everything is ready (used for `retain(true)`)
33 * Warning: locks current thread
34 */
35 void waitForReady();
36
37 /**
38 * Return AdblockEngine instance
39 * @return AdblockEngine instance. Can be `null` is not yet retained or alread y released
sergei 2018/01/19 13:56:41 Typo in "Can be `null` is not yet retained"
anton 2018/01/22 06:17:37 Acknowledged.
40 */
41 AdblockEngine getEngine();
42
43 /**
44 * Unregister AdblockEngine client
45 * @return `true` if the last instance is destroyed
46 */
47 boolean release();
48
49 /**
50 * Get registered clients count
51 * @return registered clients count
52 */
53 int getCounter();
54 }
OLDNEW

Powered by Google App Engine
This is Rietveld