Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java

Issue 29671734: Issue 6265 - Create shared AdblockEngine instance in AdblockWebView in background (Closed)
Left Patch Set: addressed Diego's comments Created Jan. 19, 2018, 12:23 p.m.
Right Patch Set: Sergey's comments Created Jan. 22, 2018, 6:19 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 { 156 {
157 // read and apply current settings 157 // read and apply current settings
158 SharedPreferences settingsPrefs = context.getSharedPreferences( 158 SharedPreferences settingsPrefs = context.getSharedPreferences(
159 settingsPreferenceName, 159 settingsPreferenceName,
160 Context.MODE_PRIVATE); 160 Context.MODE_PRIVATE);
161 161
162 storage = new SharedPrefsStorage(settingsPrefs); 162 storage = new SharedPrefsStorage(settingsPrefs);
163 } 163 }
164 164
165 /** 165 /**
166 * The method is deprecated: use .getProvider().retain() instead 166 * @deprecated The method is deprecated: use .getProvider().retain() instead
diegocarloslima 2018/01/19 12:59:19 It would be also good to add @deprecated in the ja
167 */ 167 */
168 @Deprecated public boolean retain(boolean asynchronous) 168 @Deprecated
diegocarloslima 2018/01/19 12:59:19 I would prefer this annotation as it was before, a
169 public boolean retain(boolean asynchronous)
169 { 170 {
170 return provider.retain(asynchronous); 171 return provider.retain(asynchronous);
171 } 172 }
172 173
173 /** 174 /**
174 * The method is deprecated: use .getProvider().waitForReady() instead 175 * @deprecated The method is deprecated: use .getProvider().waitForReady() ins tead
175 */ 176 */
176 @Deprecated public void waitForReady() 177 @Deprecated
178 public void waitForReady()
177 { 179 {
178 provider.waitForReady(); 180 provider.waitForReady();
179 } 181 }
180 182
181 /** 183 /**
182 * The method is deprecated: use .getProvider().getEngine() instead 184 * @deprecated The method is deprecated: use .getProvider().getEngine() instea d
183 */ 185 */
184 @Deprecated public AdblockEngine getEngine() 186 @Deprecated
187 public AdblockEngine getEngine()
185 { 188 {
186 return provider.getEngine(); 189 return provider.getEngine();
187 } 190 }
188 191
189 /** 192 /**
190 * The method is deprecated: use .getProvider().release() instead 193 * @deprecated The method is deprecated: use .getProvider().release() instead
191 */ 194 */
192 @Deprecated public boolean release() 195 @Deprecated
196 public boolean release()
193 { 197 {
194 return provider.release(); 198 return provider.release();
195 } 199 }
196 200
197 /** 201 /**
198 * The method is deprecated: use .getProvider().getCounter() instead 202 * @deprecated The method is deprecated: use .getProvider().getCounter() inste ad
199 */ 203 */
200 @Deprecated public int getCounter() 204 @Deprecated
205 public int getCounter()
201 { 206 {
202 return provider.getCounter(); 207 return provider.getCounter();
203 } 208 }
204 } 209 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld