Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: sitescripts/reports/bin/updateDigests.py

Issue 29673629: Issue 6293 - Include all false positives with report digest (Closed)
Patch Set: Created Jan. 19, 2018, 1:05 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sitescripts/reports/bin/updateDigests.py
===================================================================
--- a/sitescripts/reports/bin/updateDigests.py
+++ b/sitescripts/reports/bin/updateDigests.py
@@ -66,7 +66,7 @@
subscriptionID = subscription.get('url', 'unknown')
# Send false negatives to all subscription authors, false positives
# only to subscriptions with matching filters
- if subscriptionID in subscriptions and (dbreport['type'] == 'false negative' or subscription.get('hasmatches', 0) > 0):
+ if subscriptionID in subscriptions:
name, email = parseaddr(subscriptions[subscriptionID].email)
if email and not email in recipients:
recipients.add(email)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld