Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: lib/stats.js

Issue 29680693: [$csp3 adblockpluschrome] Issue 5241 - Avoid setting badge text before navigation is committed (Closed)
Patch Set: Created Jan. 26, 2018, 6:03 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 } 86 }
87 } 87 }
88 88
89 page.browserAction.setBadge(badge); 89 page.browserAction.setBadge(badge);
90 } 90 }
91 }); 91 });
92 }); 92 });
93 93
94 port.on("stats.getBlockedPerPage", 94 port.on("stats.getBlockedPerPage",
95 message => getBlockedPerPage(new ext.Page(message.tab))); 95 message => getBlockedPerPage(new ext.Page(message.tab)));
96
97 // We sometimes set the badge text before Chrome considers the tab to have been
98 // updated. In those cases Chrome automatically clears the text again, so the
99 // blocked count will only flash for a second. To work around that we wait for
100 // the navigation to be committed and then update the text again.
101 browser.webNavigation.onCommitted.addListener(details =>
102 {
103 let page = new ext.Page({id: details.tabId});
104 let blocked = blockedPerPage.get(page);
105
106 if (blocked)
107 {
108 page.browserAction.setBadge({
109 color: badgeColor,
110 number: blocked
111 });
112 }
113 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld