Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: templates/manifest.json.tmpl

Issue 29696596: Issue 6383 - introduce switchable app_id (Closed) Base URL: https://hg.adblockplus.org/buildtools/rev/097b8d9c43a8
Patch Set: Created Feb. 13, 2018, 3:51 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: templates/manifest.json.tmpl
diff --git a/templates/manifest.json.tmpl b/templates/manifest.json.tmpl
index e990a5b1b5f7569aa99b910d0d42f6a8a26681e2..f3176f0417798e2c479c0989bd60f2d4ab97e092 100644
--- a/templates/manifest.json.tmpl
+++ b/templates/manifest.json.tmpl
@@ -33,8 +33,8 @@
{
"gecko":
{
- "id": {{metadata.get('general', 'id')|json}}
-
+ {%- set extension_id = 'beta_id' if not releaseBuild and not devenv and metadata.has_option('general', 'beta_id') else 'id' %}
Sebastian Noack 2018/02/13 16:11:52 We have similar logic already for the Edge builds.
tlucas 2018/02/14 10:51:48 Good point - Done.
+ "id": {{metadata.get('general', extension_id)|json}}
{%- if metadata.has_section('compat') and metadata.has_option('compat', 'gecko') %}
,
"strict_min_version": {{metadata.get('compat', 'gecko')|json}}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld