Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/EngineService.java

Issue 29703555: Issue 6389 - ABP for Samsung Internet Crashes when closed on specific devices (Closed)
Patch Set: Created Feb. 20, 2018, 9:10 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/EngineService.java
===================================================================
--- a/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/EngineService.java
+++ b/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/EngineService.java
@@ -33,17 +33,17 @@ public final class EngineService extends
private volatile boolean isInitialized = false;
private Throwable failureCause = null;
private static final LinkedBlockingQueue<EngineCreatedCallbackWrapper> ON_CREATED_CALLBACKS =
new LinkedBlockingQueue<>();
@Override
public int onStartCommand(Intent intent, int flags, int startId)
{
- return Service.START_STICKY;
+ return Service.START_NOT_STICKY;
anton 2018/02/21 08:05:35 it's not clear why it happens only on Google Pixel
jens 2018/02/21 09:25:55 START_NOT_STICK does not trigger the service again
}
/**
* The callback gets executed on the UI thread.
*
* @param context
* @param callback
*/
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld