Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: README.md

Issue 29712664: Issue 6432 - Hide remove button for additional filter lists (Closed)
Left Patch Set: Created March 1, 2018, 9:43 p.m.
Right Patch Set: Reverted the colors back Created March 9, 2018, 11:25 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | background.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
(no file at all)
1 Shared Adblock Plus UI code 1 Shared Adblock Plus UI code
2 =========================== 2 ===========================
3 3
4 The user interface elements defined in this repository will be used by various 4 The user interface elements defined in this repository will be used by various
5 Adblock Plus products like Adblock Plus for Firefox. Their functionality can be 5 Adblock Plus products like Adblock Plus for Firefox. Their functionality can be
6 tested within this repository, even though they might not work exactly the same 6 tested within this repository, even though they might not work exactly the same
7 as they will do in the final product. 7 as they will do in the final product.
8 8
9 Installing dependencies 9 Installing dependencies
10 ----------------------- 10 -----------------------
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 This is the implementation of the Adblock Plus options page which is 191 This is the implementation of the Adblock Plus options page which is
192 the primary UI for changing settings and for managing filter lists. 192 the primary UI for changing settings and for managing filter lists.
193 193
194 To aid testing, the behavior of this page is affected by a number of URL 194 To aid testing, the behavior of this page is affected by a number of URL
195 parameters: 195 parameters:
196 196
197 * `addonVersion`: sets addon version application parameter that is used for 197 * `addonVersion`: sets addon version application parameter that is used for
198 creating the link to the version-specific release notes 198 creating the link to the version-specific release notes
199 * `addSubscription=true`: this parameter should trigger a dialog for adding 199 * `addSubscription=true`: this parameter should trigger a dialog for adding
200 subscriptions as initiated by clicking on an "abp:subscribe" link 200 subscriptions as initiated by clicking on an "abp:subscribe" link
201 * `additionalSubscriptions`: A comma-separated list of subscription URLs that
202 simulates scenario of persistent filter lists preinstalled by administrators.
201 * `filterError=true`: causes filter validation to fail, showing validation 203 * `filterError=true`: causes filter validation to fail, showing validation
202 errors when adding new filters on the options page 204 errors when adding new filters on the options page
203 * `blockedURLs`: a comma-separated list of URLs that should be considered 205 * `blockedURLs`: a comma-separated list of URLs that should be considered
204 blocked (necessary to test the check for blocked scripts in sharing buttons). 206 blocked (necessary to test the check for blocked scripts in sharing buttons).
205 * `downloadStatus`: sets downloadStatus parameter for filter lists, can be used 207 * `downloadStatus`: sets downloadStatus parameter for filter lists, can be used
206 to trigger various filter list download errors 208 to trigger various filter list download errors
207 * `platform=chromium`: shows the opt-out for the developer tools panel 209 * `platform=chromium`: shows the opt-out for the developer tools panel
208 * `showNotificationUI=true`: simulates user having opted-out of notifications 210 * `showNotificationUI=true`: simulates user having opted-out of notifications
209 211
210 212
211 [crowdin]: https://crowdin.com 213 [crowdin]: https://crowdin.com
LEFTRIGHT
« no previous file | background.js » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld