Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: ext/content.js

Issue 29716600: Issue 6292 - Make issue reporter compatible with test server (Closed)
Left Patch Set: Addressed Andrea's comments Created March 12, 2018, 3:44 p.m.
Right Patch Set: Fixed nits Created March 12, 2018, 3:58 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « background.js ('k') | issue-reporter.html » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 }); 95 });
96 } 96 }
97 }; 97 };
98 98
99 if (!("tabs" in browser)) 99 if (!("tabs" in browser))
100 browser.tabs = new Map([[0, {url: "example.com"}]]); 100 browser.tabs = new Map([[0, {url: "example.com"}]]);
101 101
102 browser.tabs.get = (...args) => 102 browser.tabs.get = (...args) =>
103 { 103 {
104 // Extend browser.tabs.get() 104 // Extend browser.tabs.get()
105 let result = Map.prototype.get.apply(browser.tabs, args); 105 const result = Map.prototype.get.apply(browser.tabs, args);
106 const error = new Error("Tab cannot be found"); 106 return (result ? Promise.resolve(result) :
a.giammarchi 2018/03/12 15:53:08 Nit: when there is a result, there's no actually n
saroyanm 2018/03/12 16:09:52 Done. I'm using one ternary operator to make this
107 return result ? Promise.resolve(result) : Promise.reject(error); 107 Promise.reject(new Error("Tab cannot be found")));
108 }; 108 };
109 }()); 109 }());
LEFTRIGHT

Powered by Google App Engine
This is Rietveld