Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: gni/v8.gni

Issue 29720588: Issue 6396 - Error creating non debug build config (Closed)
Patch Set: Created March 12, 2018, 11:18 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« BUILD.gn ('K') | « BUILD.gn ('k') | src/inspector/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 the V8 project authors. All rights reserved. 1 # Copyright 2016 the V8 project authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/jumbo.gni") 5 import("//build/config/jumbo.gni")
6 import("//build/config/sanitizers/sanitizers.gni") 6 import("//build/config/sanitizers/sanitizers.gni")
7 import("//build/config/v8_target_cpu.gni") 7 import("//build/config/v8_target_cpu.gni")
8 import("//build/split_static_library.gni") 8 import("//build/split_static_library.gni")
9 9
10 declare_args() { 10 declare_args() {
(...skipping 27 matching lines...) Expand all
38 # Use external files for startup data blobs: 38 # Use external files for startup data blobs:
39 # the JS builtins sources and the start snapshot. 39 # the JS builtins sources and the start snapshot.
40 v8_use_external_startup_data = "" 40 v8_use_external_startup_data = ""
41 41
42 # Enable ECMAScript Internationalization API. Enabling this feature will 42 # Enable ECMAScript Internationalization API. Enabling this feature will
43 # add a dependency on the ICU library. 43 # add a dependency on the ICU library.
44 v8_enable_i18n_support = true 44 v8_enable_i18n_support = true
45 45
46 # Use static libraries instead of source_sets. 46 # Use static libraries instead of source_sets.
47 v8_static_library = false 47 v8_static_library = false
48
49 # we need to have libv8.cr.so and some other shared libraries to link libadblo ckplus-android.so
50 v8_component_build = false
anton 2018/03/12 11:23:19 now we should add "v8_component_build=true": gn g
48 } 51 }
49 52
50 if (v8_use_external_startup_data == "") { 53 if (v8_use_external_startup_data == "") {
51 # If not specified as a gn arg, use external startup data by default if 54 # If not specified as a gn arg, use external startup data by default if
52 # a snapshot is used and if we're not on ios. 55 # a snapshot is used and if we're not on ios.
53 v8_use_external_startup_data = v8_use_snapshot && !is_ios 56 v8_use_external_startup_data = v8_use_snapshot && !is_ios
54 } 57 }
55 58
56 if (v8_enable_backtrace == "") { 59 if (v8_enable_backtrace == "") {
57 v8_enable_backtrace = is_debug && !v8_optimized_debug 60 v8_enable_backtrace = is_debug && !v8_optimized_debug
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 [ "//build/config/sanitizers:default_sanitizer_flags_but_coverage" ] 163 [ "//build/config/sanitizers:default_sanitizer_flags_but_coverage" ]
161 } else { 164 } else {
162 configs -= [ v8_path_prefix + ":v8_gcov_coverage_cflags" ] 165 configs -= [ v8_path_prefix + ":v8_gcov_coverage_cflags" ]
163 } 166 }
164 } 167 }
165 deps += [ v8_path_prefix + ":v8_dump_build_config" ] 168 deps += [ v8_path_prefix + ":v8_dump_build_config" ]
166 } 169 }
167 } 170 }
168 171
169 template("v8_component") { 172 template("v8_component") {
170 component(target_name) { 173
171 forward_variables_from(invoker, "*", [ "configs" ]) 174 if (defined(invoker.force_shared_library) && invoker.force_shared_library) {
172 configs += invoker.configs 175 shared_library(target_name) {
173 configs -= v8_remove_configs 176 output_extension = "cr.so" # override default .so with .cr.so
sergei 2018/03/12 12:43:32 it would be better to put the reason it's overridd
anton 2018/03/12 12:51:22 yes, i agree the comment could be better. Actually
jens 2018/03/13 13:17:48 You could just add a link to the ticket which expl
174 configs += v8_add_configs 177 forward_variables_from(invoker, "*", [ "configs" ])
178 configs += invoker.configs
179 configs -= v8_remove_configs
180 configs += v8_add_configs
181
182 if (is_android) {
183 configs -= [ "//build/config/android:hide_all_but_jni_onload" ]
184 }
185
186 if (!defined(deps)) {
187 deps = []
188 }
189
190 deps += [ "//build/config:exe_and_shlib_deps" ]
191 }
192 } else {
193 component(target_name) {
194 forward_variables_from(invoker, "*", [ "configs" ])
195 configs += invoker.configs
196 configs -= v8_remove_configs
197 configs += v8_add_configs
198 }
175 } 199 }
200
176 } 201 }
OLDNEW
« BUILD.gn ('K') | « BUILD.gn ('k') | src/inspector/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld