Issue 6391 - Allow running the browser unit tests with Firefox

test/runners/chromium_process.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
-const childProcess = require("child_process");
-const fs = require("fs");
-const os = require("os");
-const path = require("path");
+const {Builder} = require("selenium-webdriver");
+const chrome = require("selenium-webdriver/chrome");
+require("chromedriver");
 
-const remoteInterface = require("chrome-remote-interface");
-
+const {executeScript} = require("./webdriver");
 const {ensureChromium} = require("./chromium_download");
 
-// Chromium 60.0.3082.x
-const CHROMIUM_REVISION = 467222;
+// The Chromium version is a build number, quite obscure.
+// Chromium 63.0.3239.x is 508578
+// Chromium 65.0.3325.0 is 530368
+// We currently want Chromiun 63, as we still support it and that's the
+// loweset version that supports WebDriver.
+const CHROMIUM_REVISION = 508578;
 
-function rmdir(dirPath)
+function runScript(chromiumPath, script, scriptName, scriptArgs)
 {
-  for (let file of fs.readdirSync(dirPath))
-  {
-    let filePath = path.join(dirPath, file);
-    try
-    {
-      if (fs.statSync(filePath).isDirectory())
-        rmdir(filePath);
-      else
-        fs.unlinkSync(filePath);
-    }
-    catch (error)
-    {
-      console.error(error);
-    }
-  }
+  const options = new chrome.Options()
+        .headless()
+        .setChromeBinaryPath(chromiumPath);
 
-  try
-  {
-    fs.rmdirSync(dirPath);
-  }
-  catch (error)
-  {
-    console.error(error);
-  }
-}
+  const driver = new Builder()
+        .forBrowser("chrome")
+        .setChromeOptions(options)
+        .build();
 
-function startChromium(chromiumPath)
-{
-  fs.chmodSync(chromiumPath, fs.constants.S_IRWXU);
-
-  let dataDir = fs.mkdtempSync(path.join(os.tmpdir(), "chromium-data"));
-  let child = null;
-  return {
-    kill: () => child && child.kill(),
-    done: new Promise((resolve, reject) =>
-    {
-      child = childProcess.execFile(chromiumPath, [
-        "--headless", "--single-process", "--disable-gpu", "--no-sandbox",
-        "--allow-file-access-from-files", "--remote-debugging-port=9222",
-        "--user-data-dir=" + dataDir
-      ], error =>
-      {
-        rmdir(dataDir);
-        if (error)
-          reject(error);
-        else
-          resolve();
-      });
-    })
-  };
-}
-
-function throwException(details, url)
-{
-  let text = details.exception ? details.exception.description : details.text;
-  if (!details.stackTrace)
-  {
-    // ExceptionDetails uses zero-based line and column numbers.
-    text += `\n    at ${details.url || url}:` +
-            (details.lineNumber + 1) + ":" +
-            (details.columnNumber + 1);
-  }
-  throw text;
-}
-
-function reportMessage(text, level)
-{
-  let method = {
-    log: "log",
-    warning: "warn",
-    error: "error",
-    debug: "log",
-    info: "info"
-  }[level] || "log";
-  console[method](text);
-}
-
-function connectRemoteInterface(attempt)
-{
-  return remoteInterface().catch(error =>
-  {
-    attempt = attempt || 1;
-    if (attempt > 50)
-    {
-      // Stop trying to connect after 10 seconds
-      throw error;
-    }
-
-    return new Promise((resolve, reject) =>
-    {
-      setTimeout(() =>
-      {
-        connectRemoteInterface(attempt + 1).then(resolve).catch(reject);
-      }, 200);
-    });
-  });
-}
-
-function runScript(script, scriptName, scriptArgs)
-{
-  return connectRemoteInterface().then(async client =>
-  {
-    try
-    {
-      let {Runtime, Log, Console} = client;
-
-      console.log("\nTests in Chromium (Remote Interface)\n");

[kzar, 2018/05/04 10:52:43]

Perhaps this message should specify if the tests running are the browser tests
or the unit tests? I found the output kinda unclear so far.

[hub, 2018/05/18 00:04:22]

Done.

-
-      await Log.enable();
-      Log.entryAdded(({entry}) =>
-      {
-        reportMessage(entry.text, entry.level);
-      });
-
-      await Console.enable();
-      Console.messageAdded(({message}) =>
-      {
-        reportMessage(message.text, message.level);
-      });
-
-      await Runtime.enable();
-      let compileResult = await Runtime.compileScript({
-        expression: script,
-        sourceURL: scriptName,
-        persistScript: true
-      });
-      if (compileResult.exceptionDetails)
-        throwException(compileResult.exceptionDetails, scriptName);
-
-      let runResult = await Runtime.runScript({
-        scriptId: compileResult.scriptId
-      });
-      if (runResult.exceptionDetails)
-        throwException(runResult.exceptionDetails, scriptName);
-
-      let callResult = await Runtime.callFunctionOn({
-        objectId: runResult.result.objectId,
-        functionDeclaration: "function(...args) { return this(...args); }",
-        arguments: scriptArgs.map(arg => ({value: arg}))
-      });
-      if (callResult.exceptionDetails)
-        throwException(callResult.exceptionDetails, scriptName);
-
-      let promiseResult = await Runtime.awaitPromise({
-        promiseObjectId: callResult.result.objectId
-      });
-      if (promiseResult.exceptionDetails)
-        throwException(promiseResult.exceptionDetails, scriptName);
-    }
-    finally
-    {
-      client.close();
-    }
-  });
+  return executeScript(driver, "Chromium (WebDriver)",
+                       script, scriptName, scriptArgs);
 }
 
 module.exports = function(script, scriptName, ...scriptArgs)
 {
   return ensureChromium(CHROMIUM_REVISION).then(chromiumPath =>
   {
-    let child = startChromium(chromiumPath);
-    return Promise.race([
-      child.done,
-      runScript(script, scriptName, scriptArgs)
-    ]).then(result =>
-    {
-      child.kill();
-      return result;
-    }).catch(error =>
-    {
-      child.kill();
-      throw error;
-    });
+    return runScript(chromiumPath, script, scriptName, scriptArgs)
+      .then(result => result)
+      .catch(error =>
+      {
+        throw error;
+      });
   });
 };