Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/runners/firefox_process.js

Issue 29720661: Issue 6391 - Allow running the browser unit tests with Firefox (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Revert to default to the chrome remote interface (instead of webdriver) Created July 31, 2018, 4:56 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/runners/firefox_process.js
===================================================================
new file mode 100644
--- /dev/null
+++ b/test/runners/firefox_process.js
@@ -0,0 +1,56 @@
+/*
+ * This file is part of Adblock Plus <https://adblockplus.org/>,
+ * Copyright (C) 2006-present eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+"use strict";
+
+const {Builder} = require("selenium-webdriver");
+const firefox = require("selenium-webdriver/firefox");
+require("geckodriver");
+
+const {executeScript} = require("./webdriver");
+const {ensureFirefox} = require("./firefox_download");
+
+const FIREFOX_VERSION = "60.0b4";
kzar 2018/08/03 15:22:50 Shouldn't we use Firefox 51 here, since it's the e
hub 2018/08/03 16:13:53 57 is the recommended (supported) minimum version
kzar 2018/08/03 18:30:12 Fair enough.
+
+function runScript(firefoxPath, script, scriptName, scriptArgs)
+{
+ let binary = new firefox.Binary(firefoxPath);
+ binary.addArguments("-headless");
+
+ const options = new firefox.Options()
+ .setBinary(binary);
+
+ const driver = new Builder()
+ .forBrowser("firefox")
+ .setFirefoxOptions(options)
+ .build();
+
+ return executeScript(driver, "Firefox", script, scriptName, scriptArgs);
+}
+
+module.exports = function(script, scriptName, ...scriptArgs)
+{
+ return ensureFirefox(FIREFOX_VERSION).then(firefoxPath =>
+ {
+ return runScript(firefoxPath, script, scriptName, scriptArgs)
+ .then(result => result)
+ .catch(error =>
kzar 2018/08/03 15:22:50 How come you catch the exception, only to re-throw
hub 2018/08/03 16:13:53 catch() also deal with rejected promises.
kzar 2018/08/03 18:30:12 Acknowledged.
+ {
+ throw error;
+ });
+ });
+};

Powered by Google App Engine
This is Rietveld