pages/download.tmpl - Issue 29722640: Fixes #22 - Add download page

Side by Side Diff: pages/download.tmpl

Issue 29722640: Fixes #22 - Add download page (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org

Patch Set: Rebase Created March 21, 2018, 9:17 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 title=Download Adblock Plus

	2 description=Get Adblock Plus for free on Firefox, Chrome, Opera, Safari, Android and iOS

	3 template=minimal

	4

	5 <head>

	6 <style>

	7 header img {

	8 width: 4em;

	9 height: auto;

	10 }

	11 </style>

	12 </head>

	13

	14

	15

	16 {% set supported_devices = [

	17 {

	18 "id": "desktop",

	19 "icons": ["device-desktop.png", "device-desktop-2x.png"],

	20 "icon_alt": "Computer monitor and mouse icon",

	21 "title": "Block ads on any desktop browser",

	22 "description": "By clicking any of the links below, you agree to our " + "t erms" \| linkify + "Terms of Use</a>.",
	juliandoucette 2018/04/03 13:24:51 NIT/Suggest: <small> (semantic, not size.) NIT/Suggest: <small> (semantic, not size.) Show quoted text > The HTML <small> element makes the text font size one size smaller (for example, from large to medium, or from small to x-small) down to the browser's minimum font size. In HTML5, this element is repurposed to represent side-comments and small print, including copyright and legal text, independent of its styled presentation. > > -- mdn ire 2018/04/03 15:37:37 Ack. Done. Show quoted text On 2018/04/03 13:24:51, juliandoucette wrote: > NIT/Suggest: <small> (semantic, not size.) > > > The HTML <small> element makes the text font size one size smaller (for > example, from large to medium, or from small to x-small) down to the browser's > minimum font size. In HTML5, this element is repurposed to represent > side-comments and small print, including copyright and legal text, independent > of its styled presentation. > > > > -- mdn > Ack. Done.
	23 "platforms": [

	24 { "name": "Chrome", "url": "https://chrome.google.com/webstore/detail/cfhd ojbkjhnklbpkdaibdccddilifddb" },

	25 { "name": "Firefox", "url": "https://update.adblockplus.org/latest/adblock plusfirefox.xpi" },

	26 { "name": "Internet Explorer", "url": "https://update.adblockplus.org/late st/adblockplusie.exe" },

	27 { "name": "Safari", "url": "https://update.adblockplus.org/latest/adblockp lussafari.safariextz" },

	28 { "name": "Edge (beta)", "url": "https://www.microsoft.com/store/p/adblock -plus/9nblggh4r9nz" },

	29 { "name": "Opera", "url": "https://addons.opera.com/extensions/details/ope ra-adblock/" },

	30 { "name": "Maxthon", "url": "http://www.maxthon.com/mx5/features/ad-blocke r/" },

	31 { "name": "Yandex Browser", "url": "https://chrome.google.com/webstore/det ail/cfhdojbkjhnklbpkdaibdccddilifddb" }

	32 ]

	33 },

	34 {

	35 "id": "mobile",

	36 "icons": ["device-mobile.png", "device-mobile.svg"],

	37 "icon_alt": "Mobile icon",

	38 "title": "Block ads in your mobile browser",

	39 "platforms": [

	40 { "name": "Samsung Internet (Android)", "url": "https://play.google.com/st ore/apps/details?id=org.adblockplus.adblockplussbrowser&hl" },

	41 { "name": "Safari (iOS)", "url": "https://itunes.apple.com/app/adblock-plu s-abp-remove-ads-browse-faster-without-tracking/id1028871868?mt=8" },

	42 { "name": "Firefox", "url": "https://addons.mozilla.org/android/addon/adbl ock-plus/" }

	43 ]

	44 },

	45 {

	46 "id": "abb",

	47 "icons": ["abb-icon.png", "abb-icon-2x.png"],

	48 "icon_alt": "Adblock Browser logo",

	49 "title": "Block ads in a dedicated ad-blocking browser",

	50 "platforms": [

	51 { "name": "Adblock Browser (Android)", "url": "https://play.google.com/sto re/apps/details?id=org.adblockplus.browser" },
	saroyanm 2018/03/23 18:33:39 I noticed that we still not using redirection link I noticed that we still not using redirection links, so I also replied in the gitlab discussion. ire 2018/03/26 07:29:07 Ack. Will wait for Jeen's response. Show quoted text On 2018/03/23 18:33:39, saroyanm wrote: > I noticed that we still not using redirection links, so I also replied in the > gitlab discussion. Ack. Will wait for Jeen's response.
	52 { "name": "Adblock Browser (iOS)", "url": "https://itunes.apple.com/my/app /adblock-browser/id1015653330?mt=8&ign-itsct=1015653330-1015653330&ign-itscg=017 6&ign-mpt=uo%3D4" }

	53 ]

	54 }

	55 ] %}

	56

	57 <header class="bg-primary section content text-center">

	58 <div class="container">

	59 <img height="90px"

	60 width="90px"

	61 src="/img/download-icon.png"

	62 srcset="/img/download-icon.svg 2x"

	63 alt="{{ "White down arrow" \| translate("download-icon", "Alt text") }}" >

	64 <h1>{{ "Get Adblock Plus products on these devices" \| translate("download-he ading", "Heading") }}</h1>

	65 <p>{{ "Supported platforms" \| translate("download-subheading", "Subheading") }}</p>

	66 </div>

	67 </header>

	68

	69 <div class="item-group container text-center content">

	70 <div class="row">

	71 {% for device in supported_devices %}

	72 <div class="column one-third">
	juliandoucette 2018/04/03 13:24:51 NIT/Suggest: <article> NIT/Suggest: <article> Show quoted text > The HTML <article> element represents a self-contained composition in a document, page, application, or site, which is intended to be independently distributable or reusable (e.g., in syndication). Examples include: a forum post, a magazine or newspaper article, or a blog entry. > > -- mdn ire 2018/04/03 15:37:37 I don't think this fits within the definition of a Show quoted text On 2018/04/03 13:24:51, juliandoucette wrote: > NIT/Suggest: <article> > > > The HTML <article> element represents a self-contained composition in a > document, page, application, or site, which is intended to be independently > distributable or reusable (e.g., in syndication). Examples include: a forum > post, a magazine or newspaper article, or a blog entry. > > > > -- mdn I don't think this fits within the definition of an <article> I don't think it is self-contained. Each "device" seems to be to be part of the rest of the page, under the page title "Get Adblock Plus products on these devices". I don't think each device would be considered to be standalone.
	73 <img

	74 height="90px"

	75 width="90px"

	76 src="/img/{{ device.icons[0] }}"

	77 srcset="/img/{{ device.icons[1] }} 2x"
	juliandoucette 2018/04/03 13:24:51 NIT: You could use a dict and place device.icons.1 NIT: You could use a dict and place device.icons.1x and 2x to be more descriptive. ire 2018/04/03 15:37:37 Done. Show quoted text On 2018/04/03 13:24:51, juliandoucette wrote: > NIT: You could use a dict and place device.icons.1x and 2x to be more > descriptive. Done.
	78 alt="{{ device.icon_alt \| translate(device.id + "-icon-alt", "Alt text") }}">
	juliandoucette 2018/04/03 13:24:51 NIT: I usually imagine "id"s to be for machines an NIT: I usually imagine "id"s to be for machines and "name"s to be for humans. And it seems like you're referring to a human kind of "id" (a "name"). I think this is a PHP convention. You may consider adopting it if you like the idea. ire 2018/04/03 15:37:37 I look at "id"s simply as "identifiers". I wouldn' Show quoted text On 2018/04/03 13:24:51, juliandoucette wrote: > NIT: I usually imagine "id"s to be for machines and "name"s to be for humans. > And it seems like you're referring to a human kind of "id" (a "name"). I think > this is a PHP convention. You may consider adopting it if you like the idea. I look at "id"s simply as "identifiers". I wouldn't consider "abb" for example, to be a name, it's a simplified version of the name that I'm using an an identifier.
	79 <h2>{{ device.title \| translate(device.id + "-title", "Heading") }}</h2>
	juliandoucette 2018/04/03 13:24:50 NIT: It's unnecessary to capitalize string context NIT: It's unnecessary to capitalize string contexts. (The same applies elsewhere.) ire 2018/04/03 15:37:37 I like it capitalised. It conveys to me that it is Show quoted text On 2018/04/03 13:24:50, juliandoucette wrote: > NIT: It's unnecessary to capitalize string contexts. > > (The same applies elsewhere.) I like it capitalised. It conveys to me that it is more of a sentence/description rather than a single word/identifier.
	80 <div>

	81 {% if device.description %}

	82 <p>{{ device.description \| safe \| translate(device.id + "-description", "Paragraph") }}</p>

	83 {% endif %}

	84 <ul class="horizontal-list">

	85 {% for platform in device.platforms %}

	86 <li>

	87 {% set platform_identifier = device.id + "-product-name-" + loop.i ndex \| string %}

	88 <a href="{{ platform.url }}">{{ platform.name \| translate(platform _identifier, "Product name") }}</a>{{ ", " if loop.index != loop.length }}
	juliandoucette 2018/04/03 13:24:51 Cool :+1: Cool :+1: ire 2018/04/03 15:37:37 Thanks :p Show quoted text On 2018/04/03 13:24:51, juliandoucette wrote: > Cool :+1: Thanks :p
	89 </li>

	90 {% endfor %}

	91 </ul>

	92 </div>

	93 </div>

	94 {% endfor %}

	95 </div>

	96 </div>

OLD	NEW

« includes/features.html ('K') | « includes/features.html ('k') | static/css/index.css » ('j') | no next file with comments »