static/scss/utilities/_lists.scss - Issue 29723586: Issue 6484 - Add horizontal-list class to website-defaults

Delta Between Two Patch Sets: static/scss/utilities/_lists.scss

Issue 29723586: Issue 6484 - Add horizontal-list class to website-defaults (Closed) Base URL: https://hg.adblockplus.org/website-defaults

Left Patch Set: Created March 15, 2018, 9:37 a.m.

Right Patch Set: Rebase Created April 3, 2018, 2:41 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 // This file is part of website-defaults	1 // This file is part of website-defaults

2 // Copyright (C) 2016-present eyeo GmbH	2 // Copyright (C) 2016-present eyeo GmbH

3 //	3 //

4 // website-defaults is free software: you can redistribute it and/or	4 // website-defaults is free software: you can redistribute it and/or

5 // modify it under the terms of the GNU General Public License as published by	5 // modify it under the terms of the GNU General Public License as published by

6 // the Free Software Foundation, either version 3 of the License, or	6 // the Free Software Foundation, either version 3 of the License, or

7 // (at your option) any later version.	7 // (at your option) any later version.

8 //	8 //

9 // website-defaults is distributed in the hope that it will be useful,	9 // website-defaults is distributed in the hope that it will be useful,

10 // but WITHOUT ANY WARRANTY; without even the implied warranty of	10 // but WITHOUT ANY WARRANTY; without even the implied warranty of

11 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the	11 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

12 // GNU General Public License for more details.	12 // GNU General Public License for more details.

13 //	13 //

14 // You should have received a copy of the GNU General Public License	14 // You should have received a copy of the GNU General Public License

15 // along with website-defaults. If not, see <http://www.gnu.org/licenses/>.	15 // along with website-defaults. If not, see <http://www.gnu.org/licenses/>.

16	16

17 /*******************************************************************************	17 /*******************************************************************************

18 * Lists	18 * Lists

19 ******************************************************************************/	19 ******************************************************************************/

20	20

21 /* Horizontal List	21 /* Horizontal List

22 ******************************************************************************/	22 ******************************************************************************/

23	23

24 .horizontal-list	24 .horizontal-list,

	25 .horizontal-list li

25 {	26 {

26 display: inline;	27 display: inline;

27 list-style: none;	28 list-style: none;

28 }	29 }

29	30

30 .horizontal-list,	31 .horizontal-list,

31 .content .horizontal-list,	32 .content .horizontal-list,
juliandoucette 2018/03/24 15:48:09 I think it's OK (maybe even preferable?) to use !i I think it's OK (maybe even preferable?) to use !important for utility classes instead of adding .content specific selectors. ire 2018/03/26 06:59:39 I don't think we should use !important unless it i Show quoted text On 2018/03/24 15:48:09, juliandoucette wrote: > I think it's OK (maybe even preferable?) to use !important for utility classes > instead of adding .content specific selectors. I don't think we should use !important unless it is something that all .horizontal-list must have. I don't think zero padding is necessarily this, I can easily imagine cases where we may want to change the padding of a horizontal list.
32 [dir="rtl"] .horizontal-list	33 [dir="rtl"] .horizontal-list

33 {	34 {

34 padding: 0;	35 padding: 0;

35 }	36 }

36	37

37 .horizontal-list li	38 .comma-separated li::after
juliandoucette 2018/03/24 15:48:09 Why not just add this selector to .horizontal-list Why not just add this selector to .horizontal-list above? :) ire 2018/03/26 06:59:39 Haha don't know how I missed that! Thanks, Done. Show quoted text On 2018/03/24 15:48:09, juliandoucette wrote: > Why not just add this selector to .horizontal-list above? :) Haha don't know how I missed that! Thanks, Done.
38 {	39 {

39 display: inline;	40 content: ",";

40 list-style: none;	41 margin-right: 0.2em;

41 }	42 }

	43

	44 .comma-separated li:last-child::after

	45 {

	46 content: none;

	47 }

LEFT	RIGHT