Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: ext/background.js

Issue 29723705: Noissue - Link to extension_urls::kChromeWebstoreBaseURL in comment (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Created March 16, 2018, 4:27 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
261 browser.webNavigation.onBeforeNavigate.addListener(details => 261 browser.webNavigation.onBeforeNavigate.addListener(details =>
262 { 262 {
263 // Since we can only listen for HTTP(S) responses using 263 // Since we can only listen for HTTP(S) responses using
264 // webRequest.onHeadersReceived we must update the page structure here for 264 // webRequest.onHeadersReceived we must update the page structure here for
265 // other navigations. 265 // other navigations.
266 let {url} = details; 266 let {url} = details;
267 if (!(url.startsWith("http:") || 267 if (!(url.startsWith("http:") ||
268 url.startsWith("https:") && 268 url.startsWith("https:") &&
269 // Chrome doesn't dispatch webRequest.onHeadersReceived 269 // Chrome doesn't dispatch webRequest.onHeadersReceived
270 // for Web Store URLs. 270 // for Web Store URLs.
271 // https://crrev.com/76882bf/extensions/common/extension_urls.cc#33
271 !url.startsWith("https://chrome.google.com/webstore/"))) 272 !url.startsWith("https://chrome.google.com/webstore/")))
272 { 273 {
273 updatePageFrameStructure(details.frameId, details.tabId, url, 274 updatePageFrameStructure(details.frameId, details.tabId, url,
274 details.parentFrameId); 275 details.parentFrameId);
275 } 276 }
276 }); 277 });
277 278
278 function forgetTab(tabId) 279 function forgetTab(tabId)
279 { 280 {
280 ext.pages.onRemoved._dispatch(tabId); 281 ext.pages.onRemoved._dispatch(tabId);
(...skipping 409 matching lines...) Expand 10 before | Expand all | Expand 10 after
690 ext.windows = { 691 ext.windows = {
691 create(createData, callback) 692 create(createData, callback)
692 { 693 {
693 browser.windows.create(createData, createdWindow => 694 browser.windows.create(createData, createdWindow =>
694 { 695 {
695 afterTabLoaded(callback)(createdWindow.tabs[0]); 696 afterTabLoaded(callback)(createdWindow.tabs[0]);
696 }); 697 });
697 } 698 }
698 }; 699 };
699 } 700 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld