Issue 6510 - Configure notification opens options page incorrectly

css/desktop-options.scss

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 520 matching lines @@
   display: block;
   visibility: hidden;
 }
 
 [data-validation] .floating-input input:focus:invalid ~ .error-msg
 {
   visibility: visible;
 }
 
 /*
+  Animations
+*/
+
+.highlight-animate
+{
+  animation: highlight 1s 3;
+}
+
+@keyframes highlight
+{
+  0% { background: none }

[a.giammarchi, 2018/03/22 18:43:28]

I think the neutral value for background-color is transparent.

`none` IIRC is only for background-image, to nullify any data/url.

[saroyanm, 2018/03/22 20:43:21]

Done.

+  30% { background: #ffd7a3 }

[a.giammarchi, 2018/03/22 18:43:28]

whenever you're changing only one part of a complex CSS property, is usually
better to address it directly. background is a mess of overloads and it's able
to overwrite many other things if set directly. background-color though, is what
you are after here, so I'd go with background-color.

[saroyanm, 2018/03/22 20:43:21]

Agree, done.

+  70% { background: #ffd7a3 }
+  100% { background: none }
+}
+
+/*
   Sidebar
  */
 
 #sidebar,
 #sidebar .fixed,
 [role="tablist"]
 {
   width: 14.3rem;
 }
 
@@ skipping 1025 matching lines @@
   font-size: 1rem;
   color: #077CA6;
   background-color: #E1F2FA;
 }
 
 #notification strong
 {
   flex: 1;
   text-align: center;
 }