Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: js/desktop-options.js

Issue 29733668: Handle disabled state of AA
Left Patch Set: Hide toggle button when AA is enabled (Manvel Suggestion) Created March 26, 2018, 9 p.m.
Right Patch Set: Created March 26, 2018, 9:23 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « background.js ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 1062 matching lines...) Expand 10 before | Expand all | Expand 10 after
1073 1073
1074 function setAcceptableAds() 1074 function setAcceptableAds()
1075 { 1075 {
1076 let acceptableAdsForm = E("acceptable-ads"); 1076 let acceptableAdsForm = E("acceptable-ads");
1077 let acceptableAds = E("acceptable-ads-allow"); 1077 let acceptableAds = E("acceptable-ads-allow");
1078 let acceptableAdsPrivacy = E("acceptable-ads-privacy-allow"); 1078 let acceptableAdsPrivacy = E("acceptable-ads-privacy-allow");
1079 acceptableAdsForm.classList.remove("show-dnt-notification"); 1079 acceptableAdsForm.classList.remove("show-dnt-notification");
1080 acceptableAds.setAttribute("aria-checked", false); 1080 acceptableAds.setAttribute("aria-checked", false);
1081 acceptableAdsPrivacy.setAttribute("aria-checked", false); 1081 acceptableAdsPrivacy.setAttribute("aria-checked", false);
1082 acceptableAdsPrivacy.setAttribute("tabindex", 0); 1082 acceptableAdsPrivacy.setAttribute("tabindex", 0);
1083 if (acceptableAdsUrl in subscriptionsMap && !acceptableAdsUrl.disabled) 1083 if (acceptableAdsUrl in subscriptionsMap &&
1084 !subscriptionsMap[acceptableAdsUrl].disabled)
1084 { 1085 {
1085 acceptableAds.setAttribute("aria-checked", true); 1086 acceptableAds.setAttribute("aria-checked", true);
1086 acceptableAdsPrivacy.setAttribute("aria-disabled", false); 1087 acceptableAdsPrivacy.setAttribute("aria-disabled", false);
1087 } 1088 }
1088 else if (acceptableAdsPrivacyUrl in subscriptionsMap && 1089 else if (acceptableAdsPrivacyUrl in subscriptionsMap &&
1089 !acceptableAdsPrivacyUrl.disabled) 1090 !subscriptionsMap[acceptableAdsPrivacyUrl].disabled)
1090 { 1091 {
1091 acceptableAds.setAttribute("aria-checked", true); 1092 acceptableAds.setAttribute("aria-checked", true);
1092 acceptableAdsPrivacy.setAttribute("aria-checked", true); 1093 acceptableAdsPrivacy.setAttribute("aria-checked", true);
1093 acceptableAdsPrivacy.setAttribute("aria-disabled", false); 1094 acceptableAdsPrivacy.setAttribute("aria-disabled", false);
1094 1095
1095 // Edge uses window instead of navigator. 1096 // Edge uses window instead of navigator.
1096 // Prefer navigator first since it's the standard. 1097 // Prefer navigator first since it's the standard.
1097 if ((navigator.doNotTrack || window.doNotTrack) != 1) 1098 if ((navigator.doNotTrack || window.doNotTrack) != 1)
1098 acceptableAdsForm.classList.add("show-dnt-notification"); 1099 acceptableAdsForm.classList.add("show-dnt-notification");
1099 } 1100 }
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
1286 knownSubscription.originalTitle = subscription.title; 1287 knownSubscription.originalTitle = subscription.title;
1287 else 1288 else
1288 knownSubscription[property] = subscription[property]; 1289 knownSubscription[property] = subscription[property];
1289 } 1290 }
1290 subscription = knownSubscription; 1291 subscription = knownSubscription;
1291 } 1292 }
1292 switch (action) 1293 switch (action)
1293 { 1294 {
1294 case "disabled": 1295 case "disabled":
1295 updateSubscription(subscription); 1296 updateSubscription(subscription);
1297 if (isAcceptableAds(subscription.url))
1298 setAcceptableAds();
1299
1296 setPrivacyConflict(); 1300 setPrivacyConflict();
1297 break; 1301 break;
1298 case "downloading": 1302 case "downloading":
1299 case "downloadStatus": 1303 case "downloadStatus":
1300 case "homepage": 1304 case "homepage":
1301 case "lastDownload": 1305 case "lastDownload":
1302 case "title": 1306 case "title":
1303 updateSubscription(subscription); 1307 updateSubscription(subscription);
1304 break; 1308 break;
1305 case "added": 1309 case "added":
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
1499 "ui_warn_tracking"] 1503 "ui_warn_tracking"]
1500 }); 1504 });
1501 port.postMessage({ 1505 port.postMessage({
1502 type: "subscriptions.listen", 1506 type: "subscriptions.listen",
1503 filter: ["added", "disabled", "homepage", "lastDownload", "removed", 1507 filter: ["added", "disabled", "homepage", "lastDownload", "removed",
1504 "title", "downloadStatus", "downloading"] 1508 "title", "downloadStatus", "downloading"]
1505 }); 1509 });
1506 1510
1507 window.addEventListener("DOMContentLoaded", onDOMLoaded, false); 1511 window.addEventListener("DOMContentLoaded", onDOMLoaded, false);
1508 window.addEventListener("hashchange", onHashChange, false); 1512 window.addEventListener("hashchange", onHashChange, false);
LEFTRIGHT

Powered by Google App Engine
This is Rietveld