modules/adblockplus/templates/web/hooks_wrapper.sh.erb - Issue 29733731: #7320 - Introduce helpcenter role

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: modules/adblockplus/templates/web/hooks_wrapper.sh.erb

Issue 29733731: #7320 - Introduce helpcenter role (Closed)

Patch Set: For comments 5 and 6 Created April 10, 2018, 2:45 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 #!/bin/sh

	2 # Puppet: <%= @title %>

	3 # This script is a wrapper of accesible hooks, defined via hiera and accessed

	4 # via ssh with the ForceCommand option.

	5

	6 usage()

	7 {

	8 echo "Avaiable commands are:"

	9 echo "help"

	10 <% @hooks.keys.each do \|key\| -%>

	11 echo "<%= key %>"

	12 <% end -%>

	13 }

	14

	15 command="$1"; shift

	16 case "$command" in

	17 "help")

	18 usage

	19 ;;

	20 <% @hooks.each do \|command, values\| -%>
	mathias 2018/04/17 15:57:13 Why the double space here? Why the double space here? f.lopez 2018/04/17 18:02:22 Acknowledged. Show quoted text On 2018/04/17 15:57:13, mathias wrote: > Why the double space here? Acknowledged.
	21 "<%= command %>")

	22 <%= scope.function_join([[@wrapper_path, command], "/"]) %> "$@"
	mathias 2018/04/17 15:57:14 Why not use Ruby's very own join method here? Also Why not use Ruby's very own join method here? Also the path to the hook should be in quotes. f.lopez 2018/04/17 18:02:22 Acknowledged. Show quoted text On 2018/04/17 15:57:14, mathias wrote: > Why not use Ruby's very own join method here? > Also the path to the hook should be in quotes. Acknowledged.
	23 ;;

	24 <% end -%>

	25 *)

	26 echo "Unrecognized command"

	27 usage

	28 exit 1

	29 ;;

	30 esac

	31

OLD	NEW