Unified Diff: desktop-options.html
Issue 29736629:
Issue 6532 - Removes required subscription title input field (Closed)
Base URL: https://hg.adblockplus.org/adblockplusui
Patch Set:
Created March 30, 2018, 3:30 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
locale/ar/desktop-options.json » ('j')
|
locale/en_US/desktop-options.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: desktop-options.html |
| =================================================================== |
| --- a/desktop-options.html |
| +++ b/desktop-options.html |
| @@ -394,22 +394,16 @@ |
| </button> |
| </template> |
| </ul> |
| </div> |
| <!-- Add import subscription --> |
| <div id="dialog-content-import" class="dialog-content"> |
| <form data-validation="custom" novalidate> |
| <p class="floating-input"> |
| - <input placeholder=" " id="import-list-title" type="text" class="default-focus" required /> |
|
Thomas Greiner
2018/04/03 14:11:04
You're removing an element with the class "default
Thomas Greiner
2018/04/03 14:11:04
We're still trying to access its value in js/deskt
Jon Sonesen
2018/04/06 01:10:09
Acknowledged.
|
| - <label for="import-list-title" class="i18n_options_dialog_import_subscription_title"></label> |
| - <span class="icon attention"></span> |
| - <span class="i18n_options_dialog_import_subscription_title_error error-msg"></span> |
| - </p> |
| - <p class="floating-input"> |
|
Jon Sonesen
2018/03/30 03:37:19
One thing I was thinking, is that maybe this doesn
Thomas Greiner
2018/04/03 14:11:04
"Floating input" doesn't refer to CSS's "float" pr
Jon Sonesen
2018/04/06 01:10:09
Acknowledged.
|
| <input placeholder=" " id="import-list-url" type="url" required/> |
| <label for="import-list-url" class="i18n_options_dialog_import_subscription_location"></label> |
| <span class="icon attention"></span> |
| <span class="i18n_options_dialog_import_subscription_location_error error-msg"></span> |
| </p> |
| <p class="side-controls"> |
| <button class="i18n_options_customFilter_cancel secondary" type="reset" data-action="close-dialog"></button> |
| <button type="button" class="i18n_options_dialog_import_title primary" data-action="validate-import-subscription"></button> |
« no previous file with comments
|
« no previous file
|
locale/ar/desktop-options.json » ('j')
|
locale/en_US/desktop-options.json » ('J')
