js/desktop-options.js - Issue 29736629: Issue 6532 - Removes required subscription title input field

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: js/desktop-options.js

Issue 29736629: Issue 6532 - Removes required subscription title input field (Closed) Base URL: https://hg.adblockplus.org/adblockplusui

Patch Set: Address PS2 comments Created April 9, 2018, 8:46 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: js/desktop-options.js

===================================================================

--- a/js/desktop-options.js

+++ b/js/desktop-options.js

@@ -732,18 +732,17 @@

break;

case "validate-import-subscription":

let form = findParentData(element, "validation", true);

if (!form)

return;

if (form.checkValidity())

{

- addEnableSubscription(E("import-list-url").value,

- E("import-list-title").value);

+ addEnableSubscription(E("import-list-url").value);

form.reset();

closeDialog();

}

else

{

form.querySelector(":invalid").focus();

}

break;

« no previous file with comments | « desktop-options.html ('k') | locale/en_US/desktop-options.json » ('j') | no next file with comments »