Noissue - Trim spaces around element hiding emulation selectors

lib/filterClasses.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 170 matching lines @@
   text = text.replace(/[^\S ]+/g, "");
 
   // Don't remove spaces inside comments
   if (/^ *!/.test(text))
     return text.trim();
 
   // Special treatment for element hiding filters, right side is allowed to
   // contain spaces
   if (Filter.elemhideRegExp.test(text))
   {
-    let [, domain, separator, selector] = /^(.*?)(#@?#?)(.*)$/.exec(text);
+    let [, domain, separator, selector] = /^(.*?)(#[@?]?#?)(.*)$/.exec(text);

[Manish Jethani, 2018/04/08 09:40:09]

It seems we forgot to include the "#?#" case here.

If you run Filter.normalize on
"foo.com,  bar.com  #?#  #header,  .footer" it gives
"foo.com,bar.com#?#  #header,  .footer" rather than
"foo.com,bar.com#?##header,  .footer".

[kzar, 2018/04/09 10:38:29]

Shouldn't the question mark be escaped?

[hub, 2018/04/09 15:02:07]

In between the [], it doesn't need to. It is taken literally.

[kzar, 2018/04/09 15:29:46]

Acknowledged.

     return domain.replace(/ +/g, "") + separator + selector.trim();
   }
 
   // For most regexp filters we strip all spaces, but $csp filter options
   // are allowed to contain single (non trailing) spaces.
   let strippedText = text.replace(/ +/g, "");
   if (!strippedText.includes("$") || !/\bcsp=/i.test(strippedText))
     return strippedText;
 
   let optionsMatch = Filter.optionsRegExp.exec(strippedText);
@@ skipping 878 matching lines @@
  */
 function ElemHideEmulationFilter(text, domains, selector)
 {
   ElemHideBase.call(this, text, domains, selector);
 }
 exports.ElemHideEmulationFilter = ElemHideEmulationFilter;
 
 ElemHideEmulationFilter.prototype = extend(ElemHideBase, {
   type: "elemhideemulation"
 });