#8852 - ldap sync output filter

edit.sh

 #!/bin/sh
-#####################################################################
-#####################################################################
-##   The cause of this script is to make the output of the LDAP    ##
-##   sync cron job more readable by filtering all repeated lines   ##
-#####################################################################
-#####################################################################

[f.lopez, 2018/05/15 00:51:19]

"Filters out repeated lines from LDAP sync cron job output"

Or something like that, no need to put `The cause of this script` or whatever,
the shorter, the better (unlike my codereviews)

Also, no need to add 4 lines of pure `#`.
Just one `#` is enough for the actual documentation

 
-last_updated=""
+# Filter out uninformative output lines from the ldap-sync cron job script
 
-while IFS= read -r line; do

[f.lopez, 2018/05/15 00:51:19]

This IFS set is redundant here because you are quoting `$line`.
Quoting of variables avoid expansions and word splitting, among other things.

On a side note, I wonder if the loop is necessary, can't you just pass the whole
text? I don't have an example to test this, but maybe you can avoid looping
through every line.

-  if echo "$line" | grep -q "Updating" ||

[f.lopez, 2018/05/15 00:51:19]

can't you avoid repeating yourself here with the `-e` flag?

for example(untested code):

```
if echo "$line" | grep -e "Updating" \
                       -e "Creating"
```

-     echo "$line" | grep -q "Creating"
-  then
-    last_updated="$line"
-  fi
+last_action=""
 
-  if echo "$line" | grep -q -v "Updating" &&

[f.lopez, 2018/05/15 00:51:19]

You can use the `-F` flag for all lines so you don't repeat yourself,

something like this (untested code):

```
patterns="Updating
Creating
Found
#
Synchronizing
->"

if echo "$line" | grep -q -v -F "${patterns}"
```
The -F flag works here cause it needs to match all of them.

-     echo "$line" | grep -q -v "Creating" &&
-     echo "$line" | grep -q -v "Found" &&
-     echo "$line" | grep -q -v "#" &&
-     echo "$line" | grep -q -v "Synchronizing" &&
-     echo "$line" | grep -q -v -F -e "->"
-  then
-    echo $line 

[f.lopez, 2018/05/15 00:51:19]

my editor shows an empty space at the end of this line, please make sure there
is no empty spaces at the end of any line

-  fi
+while read line; do
+  case "$line" in
+    *-\>*)
+      if [ ! -z "$last_action" ]
+      then
+        echo "$last_action"
+      fi
 
-  if echo "$line" | grep -q -F -e "->"

[f.lopez, 2018/05/15 00:51:19]

no need for `-F` flag since you are matching a single pattern.

no need for `-e` flag since you are not using regex either.

-  then
-    echo $last_updated
-    echo $line

[f.lopez, 2018/05/15 00:51:19]

Quote both lines here

http://www.tldp.org/LDP/abs/html/quoting.html

-  fi
+      echo "$line"
+      last_action=""
+      ;;
+    --\ Found\ *\ users* | \
+    \#* | \
+    *Synchronizing\ *\ groups* | \
+    \*\*\ Synchronizing\ *\ users* | \
+    --\ Updating\ user\ \'*\'?\(*\)* | \
+    --\ Updating\ group\ \'*\'* | \
+    --\ Creating\ user\ \'*\'?\(*\)* | \
+    --\ Creating\ group\ \'*\'*)
+      last_action="$line"
+      ;;
+    *)
+      echo "$line"
+      ;;
+  esac
 done

[f.lopez, 2018/05/15 00:51:19]

add an empty line at the end of the file