Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/snippets.js

Issue 29761597: Issue 6538, 6781 - Implement script parsing for snippets (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Created April 25, 2018, 5:25 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/snippets.js » ('j') | test/snippets.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/snippets.js
===================================================================
--- a/lib/snippets.js
+++ b/lib/snippets.js
@@ -70,12 +70,66 @@
let filter = Filter.fromText(text);
if (filter.isActiveOnDomain(domain) &&
!ElemHide.getException(filter, domain))
{
result.push(filter);
}
}
return result;
+ },
+
+ /**
+ * Parses a script and returns a list of all its commands and their arguments
+ * @param {string} script
+ * @return {Array.<string[]>}
Manish Jethani 2018/04/26 13:25:17 I had to use Array.<string[]> instead of string[][
+ */
+ parseScript(script)
+ {
+ let tree = [];
+
+ let escape = false;
+ let literal = false;
+
+ let call = [];
+ let argument = "";
+
+ for (let character of [...script.trim(), ";"])
Manish Jethani 2018/04/26 13:25:17 The parsing here is as per the specification in Tr
+ {
+ if (escape)
+ {
+ escape = false;
+
+ argument += character;
+ }
+ else if (character == "\\")
+ {
+ escape = true;
+ }
+ else if (character == "'")
+ {
+ literal = !literal;
+ }
+ else if (literal || character != ";" && !/\s/u.test(character))
+ {
+ argument += character;
+ }
+ else
+ {
+ if (argument)
+ {
+ call.push(argument);
+ argument = "";
+ }
+
+ if (character == ";" && call.length > 0)
+ {
+ tree.push(call);
+ call = [];
+ }
+ }
+ }
+
+ return tree;
}
};
exports.Snippets = Snippets;
« no previous file with comments | « no previous file | test/snippets.js » ('j') | test/snippets.js » ('J')

Powered by Google App Engine
This is Rietveld