Issue 6665 - Split out element hiding exceptions into their own module

test/elemHide.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 41 matching lines @@
   test.deepEqual(
     normalizeSelectors(ElemHide.getSelectorsForDomain(domain, specificOnly)),
     normalizedExpectedSelectors
   );
 }
 
 exports.testGetSelectorsForDomain = function(test)
 {
   let addFilter = filterText => ElemHide.add(Filter.fromText(filterText));
   let removeFilter = filterText => ElemHide.remove(Filter.fromText(filterText));
   let addException =

[Manish Jethani, 2018/05/17 05:42:48]

We could just add type checks to addFilter and removeFilter above, but it's
cleaner to have separate addException and removeException functions in my
opinion (makes the code easier to read).

     filterText => ElemHideExceptions.add(Filter.fromText(filterText));
   let removeException =
     filterText => ElemHideExceptions.remove(Filter.fromText(filterText));
 
   testResult(test, "", []);
 
   addFilter("~foo.example.com,example.com##foo");
   testResult(test, "barfoo.example.com", ["foo"]);
   testResult(test, "bar.foo.example.com", []);
   testResult(test, "foo.example.com", []);
@@ skipping 105 matching lines @@
 
   removeFilter("~foo.example.com,example.com##foo");
 
   // Test criteria
   addFilter("##hello");
   addFilter("~example.com##world");
   addFilter("foo.com##specific");
   testResult(test, "foo.com", ["specific"], true);
   testResult(test, "foo.com", ["hello", "specific", "world"], false);
   testResult(test, "foo.com", ["hello", "specific", "world"]);
+  testResult(test, "foo.com.", ["hello", "specific", "world"]);
+  testResult(test, "example.com", [], true);
   removeFilter("foo.com##specific");
   removeFilter("~example.com##world");
   removeFilter("##hello");
   testResult(test, "foo.com", []);
 
   addFilter("##hello");
   testResult(test, "foo.com", [], true);
   testResult(test, "foo.com", ["hello"], false);
   testResult(test, "foo.com", ["hello"]);
   testResult(test, "bar.com", [], true);
@@ skipping 39 matching lines @@
 };
 
 exports.testZeroFilterKey = function(test)
 {
   ElemHide.add(Filter.fromText("##test"));
   ElemHideExceptions.add(Filter.fromText("foo.com#@#test"));
   testResult(test, "foo.com", []);
   testResult(test, "bar.com", ["test"]);
   test.done();
 };