Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: modules/adblockplus/templates/web/fileserver.conf.erb
Issue
29795567
:
#11371 - Password protection for fileserver repositories (Closed)
Patch Set: Didnt remove unnecessary file
Created May 31, 2018, 4:20 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Didnt remove unnecessary file
Patch Set 3: Uploaded a file by mistake
Patch Set 4: For comment 4
Patch Set 5: For comment 7
Right:
Patch Set 1: None
Patch Set 2: Didnt remove unnecessary file
Patch Set 3: Uploaded a file by mistake
Patch Set 4: For comment 4
Patch Set 5: For comment 7
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
hiera/roles/web/adblockbrowser.yaml
modules/adblockplus/files/nginx/fileserver.conf
modules/adblockplus/manifests/web/fileserver.pp
modules/adblockplus/manifests/web/fileserver/repository.pp
modules/adblockplus/templates/web/fileserver.conf.erb
View unified diff
|
Download patch
« no previous file with comments
|
« modules/adblockplus/manifests/web/fileserver/repository.pp
('k') |
no next file »
|
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
# Puppet: <%= @title %>
2
3
location / {
4
root /var/www/$host;
5
<% if !@auth_users.empty? -%>
6
auth_basic "Password protected";
7
auth_basic_user_file <%= @auth_file%>;
8
<% end -%>
9
}
OLD
NEW
« no previous file with comments
|
« modules/adblockplus/manifests/web/fileserver/repository.pp
('k') |
no next file »
|
no next file with comments »
Edit Message
Issue 29795567: #11371 - Password protection for fileserver repositories (Closed)
Created May 31, 2018, 4:19 p.m. by f.lopez
Modified June 6, 2018, 4:09 p.m.
Reviewers: mathias, Fred
Base URL:
Comments: 10
This is Rietveld