Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: lib/filterClasses.js

Issue 29801558: Issue 6737 - Use String.includes instead of String.indexOf (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Replace more instances Created June 7, 2018, 9:51 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « lib/downloader.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 723 matching lines...) Expand 10 before | Expand all | Expand 10 after
734 734
735 let contentType = null; 735 let contentType = null;
736 let matchCase = null; 736 let matchCase = null;
737 let domains = null; 737 let domains = null;
738 let sitekeys = null; 738 let sitekeys = null;
739 let thirdParty = null; 739 let thirdParty = null;
740 let collapse = null; 740 let collapse = null;
741 let csp = null; 741 let csp = null;
742 let rewrite = null; 742 let rewrite = null;
743 let options; 743 let options;
744 let match = (text.indexOf("$") >= 0 ? Filter.optionsRegExp.exec(text) : null); 744 let match = text.includes("$") ? Filter.optionsRegExp.exec(text) : null;
745 if (match) 745 if (match)
746 { 746 {
747 options = match[1].split(","); 747 options = match[1].split(",");
748 text = match.input.substr(0, match.index); 748 text = match.input.substr(0, match.index);
749 for (let option of options) 749 for (let option of options)
750 { 750 {
751 let value = null; 751 let value = null;
752 let separatorIndex = option.indexOf("="); 752 let separatorIndex = option.indexOf("=");
753 if (separatorIndex >= 0) 753 if (separatorIndex >= 0)
754 { 754 {
(...skipping 327 matching lines...) Expand 10 before | Expand all | Expand 10 after
1082 */ 1082 */
1083 function ElemHideEmulationFilter(text, domains, selector) 1083 function ElemHideEmulationFilter(text, domains, selector)
1084 { 1084 {
1085 ElemHideBase.call(this, text, domains, selector); 1085 ElemHideBase.call(this, text, domains, selector);
1086 } 1086 }
1087 exports.ElemHideEmulationFilter = ElemHideEmulationFilter; 1087 exports.ElemHideEmulationFilter = ElemHideEmulationFilter;
1088 1088
1089 ElemHideEmulationFilter.prototype = extend(ElemHideBase, { 1089 ElemHideEmulationFilter.prototype = extend(ElemHideBase, {
1090 type: "elemhideemulation" 1090 type: "elemhideemulation"
1091 }); 1091 });
OLDNEW
« no previous file with comments | « lib/downloader.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld