hiera/roles/web/redirect/eyeo.yaml - Issue 29806555: #12222 - Add redirects for ABP installation links

Side by Side Diff: hiera/roles/web/redirect/eyeo.yaml

Issue 29806555: #12222 - Add redirects for ABP installation links (Closed)

Patch Set: Created June 13, 2018, 3:07 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 classes:	1 classes:

2 adblockplus::web::redirector:	2 adblockplus::web::redirector:

3 domain: "eyeo.to"	3 domain: "eyeo.to"

4 default: "https://eyeo.com/"	4 default: "https://eyeo.com/"

5	5

6 adblockplus::web::redirector::targets:	6 adblockplus::web::redirector::targets:

7 acceptableads: "https://acceptableads.com/"	7 acceptableads: "https://acceptableads.com/"

8 adblockbrowser: "https://adblockbrowser.org/"	8 adblockbrowser: "https://adblockbrowser.org/"

9 adblockbrowser/android: "https://play.google.com/store/apps/details?id=org.adb lockplus.browser"	9 adblockbrowser/android: "https://play.google.com/store/apps/details?id=org.adb lockplus.browser"

10 adblockbrowser/ios: "https://itunes.apple.com/app/adblock-browser-best-ad-bloc ker/id1015653330"	10 adblockbrowser/ios: "https://itunes.apple.com/app/adblock-browser-best-ad-bloc ker/id1015653330"

(...skipping 42 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
53 adblockplus/sbrowser_samsung_internet_store/galaxy_apps: "https://apps.samsung .com/appquery/appDetail.as?appId=com.sec.android.app.sbrowser"	53 adblockplus/sbrowser_samsung_internet_store/galaxy_apps: "https://apps.samsung .com/appquery/appDetail.as?appId=com.sec.android.app.sbrowser"

54 adblockplus/sbrowser_samsung_internet_store/app_store_360: "http://zhushou.360 .cn/detail/index/soft_id/3248635?recrefer=SE_D_三星浏览器"	54 adblockplus/sbrowser_samsung_internet_store/app_store_360: "http://zhushou.360 .cn/detail/index/soft_id/3248635?recrefer=SE_D_三星浏览器"

55 adblockplus/sbrowser_samsung_internet_store/baidu: "https://shouji.baidu.com/s oftware/22835675.html"	55 adblockplus/sbrowser_samsung_internet_store/baidu: "https://shouji.baidu.com/s oftware/22835675.html"

56 adblockplus/sbrowser_samsung_internet_store/tencent: "http://sj.qq.com/myapp/d etail.htm?apkName=com.sec.android.app.sbrowser"	56 adblockplus/sbrowser_samsung_internet_store/tencent: "http://sj.qq.com/myapp/d etail.htm?apkName=com.sec.android.app.sbrowser"

57 adblockplus/sbrowser_samsung_internet_store: "https://www.samsung.com/de/apps/ samsung-internet/"	57 adblockplus/sbrowser_samsung_internet_store: "https://www.samsung.com/de/apps/ samsung-internet/"

58 adblockplus/help_center: "https://help.eyeo.com/"	58 adblockplus/help_center: "https://help.eyeo.com/"

59 adblockplus/firefox_install: "https://addons.mozilla.org/firefox/downloads/lat est/adblock-plus/"	59 adblockplus/firefox_install: "https://addons.mozilla.org/firefox/downloads/lat est/adblock-plus/"

60 adblockplus/acceptable_ads_opt_out: "https://adblockplus.org/acceptable-ads#op tout?"	60 adblockplus/acceptable_ads_opt_out: "https://adblockplus.org/acceptable-ads#op tout?"

61 adblockplus/terms: "https://adblockplus.org/terms"	61 adblockplus/terms: "https://adblockplus.org/terms"

62 adblockplus/eyeo: "https://eyeo.com/?"	62 adblockplus/eyeo: "https://eyeo.com/?"

	63 adblockplus/opera_install: "https://addons.opera.com/extensions/details/opera- adblock/"

	64 adblockplus/ie_install: "https://update.adblockplus.org/latest/adblockplusie.e xe"

	65 adblockplus/safari_install: "https://update.adblockplus.org/latest/adblockplus safari.safariextz"

	66 adblockplus/ios_install: "https://itunes.apple.com/us/app/adblock-plus-abp-rem ove-ads-browse-faster-without-tracking/id1028871868?mt=8"

	67 adblockplus/edge_install: "https://www.microsoft.com/store/p/adblock-plus/9nbl ggh4r9nz"
	mathias 2018/06/13 17:52:00 Please add `?` signs to the end of the target link Please add `?` signs to the end of the target links, e.g. `foo: https://example.com/bar?`, otherwise any incoming query parameters (GET) will get included with the redirect. This is something I just re-learned recently, though we've discovered and worked around it the same way before. See i.e. `adblockplus/eyeo` above. Also please note that I do not know how to prevent this from happening when the target link includes GET parameters itself (some of the new ones here do as well). IIRC one can write something like `foo: bar?baz=1?` to achieve the sane, though you would need to test that upfront. f.lopez 2018/06/13 19:16:27 Your recall is correct, after the last ? the param Show quoted text On 2018/06/13 17:52:00, mathias wrote: > Please add `?` signs to the end of the target links, e.g. `foo: > https://example.com/bar?%60, otherwise any incoming query parameters (GET) will > get included with the redirect. > > This is something I just re-learned recently, though we've discovered and worked > around it the same way before. See i.e. `adblockplus/eyeo` above. Also please > note that I do not know how to prevent this from happening when the target link > includes GET parameters itself (some of the new ones here do as well). IIRC one > can write something like `foo: bar?baz=1?` to achieve the sane, though you would > need to test that upfront. Your recall is correct, after the last ? the parameters won't be included in the redirect, I'll add a follow up codereview for this since I already pushed this change
OLD	NEW