Unified Diff: lib/requestBlocker.js
Issue 29828591:
Issue 6787 - Apply rewrite filter even if the rewrite URL is blank (Closed)
Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Use typeof instead
Created July 12, 2018, 12:05 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: lib/requestBlocker.js |
| =================================================================== |
| --- a/lib/requestBlocker.js |
| +++ b/lib/requestBlocker.js |
| @@ -189,17 +189,17 @@ |
| let [filter, thirdParty] = matchRequest(url, type, docDomain, |
| sitekey, specificOnly); |
| let result; |
| let rewrittenUrl; |
| if (filter instanceof BlockingFilter) |
| { |
| - if (filter.rewrite) |
| + if (typeof filter.rewrite == "string") |
| { |
| rewrittenUrl = filter.rewriteUrl(details.url); |
| // If no rewrite happened (error, different origin), we'll |
| // return undefined in order to avoid an "infinite" loop. |
| if (rewrittenUrl != details.url) |
| result = {redirectUrl: rewrittenUrl}; |
| } |
| else |
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
