Unified Diff: test/runners/chromium_process.js
Issue 29858555:
Issue 6391 - WebDriver: Fix runtime problen with Gecko and Firefox (Closed)
Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Fixed Firefox too and now run by default also with Firefox
Created Aug. 21, 2018, 2 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« README.md ('k')
|
test/runners/firefox_process.js » ('j')
|
test/runners/firefox_process.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: test/runners/chromium_process.js |
| =================================================================== |
| --- a/test/runners/chromium_process.js |
| +++ b/test/runners/chromium_process.js |
| @@ -30,16 +30,18 @@ |
| // We currently want Chromiun 63, as we still support it and that's the |
| // loweset version that supports WebDriver. |
| const CHROMIUM_REVISION = 508578; |
| function runScript(chromiumPath, script, scriptName, scriptArgs) |
| { |
| const options = new chrome.Options() |
| .headless() |
| + // disabling sandboxing. It is needed on some systems. |
|
Sebastian Noack
2018/08/22 17:02:04
Nit: Proper capitalization and punctuation please:
hub
2018/08/22 17:36:55
Done.
|
| + .addArguments("--no-sandbox") |
| .setChromeBinaryPath(chromiumPath); |
| const driver = new Builder() |
| .forBrowser("chrome") |
| .setChromeOptions(options) |
| .build(); |
| return executeScript(driver, "Chromium (WebDriver)", |
« no previous file with comments
|
« README.md ('k')
|
test/runners/firefox_process.js » ('j')
|
test/runners/firefox_process.js » ('J')
