Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/runners/firefox_process.js

Issue 29858555: Issue 6391 - WebDriver: Fix runtime problen with Gecko and Firefox (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Updated comments Created Aug. 22, 2018, 5:36 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/runners/chromium_process.js ('k') | test_runner.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runners/firefox_process.js
===================================================================
--- a/test/runners/firefox_process.js
+++ b/test/runners/firefox_process.js
@@ -19,17 +19,19 @@
const {Builder} = require("selenium-webdriver");
const firefox = require("selenium-webdriver/firefox");
require("geckodriver");
const {executeScript} = require("./webdriver");
const {ensureFirefox} = require("./firefox_download");
-const FIREFOX_VERSION = "56.0";
+// Firefox 57 seems to be the minimum to reliably run with WebDriver
+// on certain system configurations like Debian 9, TravisCI.
+const FIREFOX_VERSION = "57.0";
function runScript(firefoxPath, script, scriptName, scriptArgs)
{
let binary = new firefox.Binary(firefoxPath);
binary.addArguments("-headless");
const options = new firefox.Options()
.setBinary(binary);
« no previous file with comments | « test/runners/chromium_process.js ('k') | test_runner.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld